From: Dave Hansen <dave@linux.vnet.ibm.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Mel Gorman <mgorman@suse.de>
Subject: Re: [PATCH] Debugging: Keep track of page owners
Date: Fri, 07 Dec 2012 14:58:57 -0800 [thread overview]
Message-ID: <50C274B1.90408@linux.vnet.ibm.com> (raw)
In-Reply-To: <20121207144428.98b3eaf4.akpm@linux-foundation.org>
On 12/07/2012 02:44 PM, Andrew Morton wrote:
> AFACIT that difference was undescribed. I can see that the new version
> uses the stack-tracing infrastructure, but the change to
> pagetypeinfo_showmixedcount_print() is a mystery.
Ahhh, I assume you're talking about this hunk:
>> @@ -976,10 +976,7 @@ static void pagetypeinfo_showmixedcount_print(struct seq_file *m,
>>
>> pagetype = allocflags_to_migratetype(page->gfp_mask);
>> if (pagetype != mtype) {
>> - if (is_migrate_cma(pagetype))
>> - count[MIGRATE_MOVABLE]++;
>> - else
>> - count[mtype]++;
>> + count[mtype]++;
>> break;
>> }
That was to fix the comment that Laura Abbott made about it miscounting
MIGRATE_CMA pages.
My patch-sending scripts were choking a bit on the text description in
your patch. I'm using a long-ago-forked copy of your patch-utils and
the DESC/EDESC in the patch I imported is giving them fits when I send
via email and stripping large parts of the description. I'm happy to
resend via email, too, but here, the raw patch (will the full description):
https://www.sr71.net/~dave/linux/pageowner.patch
The important description that the scripts managed to strip out when
emailed was this:
Updated 12/4/2012 - should apply to 3.7 kernels. I did a quick
sniff-test to make sure that this boots and produces some sane
output, but it's not been exhaustively tested.
* Moved file over to debugfs (no reason to keep polluting /proc)
* Now using generic stack tracking infrastructure
* Added check for MIGRATE_CMA pages to explicitly count them
as movable.
The new snprint_stack_trace() probably belongs in its own patch
if this were to get merged, but it won't kill anyone as it stands.
-----
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-12-07 22:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-07 21:24 [PATCH] Debugging: Keep track of page owners Dave Hansen
2012-12-07 22:26 ` Andrew Morton
2012-12-07 22:37 ` Dave Hansen
2012-12-07 22:44 ` Andrew Morton
2012-12-07 22:58 ` Dave Hansen [this message]
2012-12-08 2:51 ` Steven Rostedt
2012-12-08 2:58 ` Steven Rostedt
-- strict thread matches above, loose matches on Subject: below --
2012-12-05 1:12 Dave Hansen
2012-12-05 15:01 ` Laura Abbott
2012-12-05 17:48 ` Dave Hansen
2012-12-05 22:36 ` Andrew Morton
2012-12-07 16:37 ` Laura Abbott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50C274B1.90408@linux.vnet.ibm.com \
--to=dave@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).