From: Dave Hansen <dave@linux.vnet.ibm.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Davidlohr Bueso <davidlohr.bueso@hp.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] mm: add node physical memory range to sysfs
Date: Fri, 07 Dec 2012 16:17:36 -0800 [thread overview]
Message-ID: <50C28720.3070205@linux.vnet.ibm.com> (raw)
In-Reply-To: <20121207155125.d3117244.akpm@linux-foundation.org>
On 12/07/2012 03:51 PM, Andrew Morton wrote:
>> > +static ssize_t node_read_memrange(struct device *dev,
>> > + struct device_attribute *attr, char *buf)
>> > +{
>> > + int nid = dev->id;
>> > + unsigned long start_pfn = NODE_DATA(nid)->node_start_pfn;
>> > + unsigned long end_pfn = start_pfn + NODE_DATA(nid)->node_spanned_pages;
> hm. Is this correct for all for
> FLATMEM/SPARSEMEM/SPARSEMEM_VMEMMAP/DISCONTIGME/etc?
It's not _wrong_ per se, but it's not super precise, either.
The problem is, it's quite valid to have these node_start/spanned ranges
overlap between two or more nodes on some hardware. So, if the desired
purpose is to map nodes to DIMMs, then this can only accomplish this on
_some_ hardware, not all. It would be completely useless for that
purpose for some configurations.
Seems like the better way to do this would be to expose the DIMMs
themselves in some way, and then map _those_ back to a node.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-12-08 0:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-07 22:34 [PATCH] mm: add node physical memory range to sysfs Davidlohr Bueso
2012-12-07 23:51 ` Andrew Morton
2012-12-08 0:17 ` Dave Hansen [this message]
2012-12-13 1:18 ` Davidlohr Bueso
2012-12-13 1:48 ` Dave Hansen
2012-12-13 2:03 ` Davidlohr Bueso
2012-12-13 4:49 ` Dave Hansen
2012-12-13 15:17 ` KOSAKI Motohiro
2012-12-13 23:15 ` Davidlohr Bueso
2012-12-14 0:18 ` Dave Hansen
2012-12-08 19:45 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50C28720.3070205@linux.vnet.ibm.com \
--to=dave@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=davidlohr.bueso@hp.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).