From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA080C2D0DB for ; Thu, 30 Jan 2020 22:18:06 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9D3102082E for ; Thu, 30 Jan 2020 22:18:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qZDwMV4c" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9D3102082E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3C3AA6B0396; Thu, 30 Jan 2020 17:18:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 374176B0398; Thu, 30 Jan 2020 17:18:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 28A2E6B0399; Thu, 30 Jan 2020 17:18:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0046.hostedemail.com [216.40.44.46]) by kanga.kvack.org (Postfix) with ESMTP id 12BD36B0396 for ; Thu, 30 Jan 2020 17:18:06 -0500 (EST) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id C316E181AEF10 for ; Thu, 30 Jan 2020 22:18:05 +0000 (UTC) X-FDA: 76435714530.17.rod59_63bd9b5d3663b X-HE-Tag: rod59_63bd9b5d3663b X-Filterd-Recvd-Size: 4460 Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by imf14.hostedemail.com (Postfix) with ESMTP for ; Thu, 30 Jan 2020 22:18:05 +0000 (UTC) Received: by mail-wm1-f68.google.com with SMTP id p9so5612178wmc.2 for ; Thu, 30 Jan 2020 14:18:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=GL8YlOuK+lPzvntmToerBw7cag+fxZ5AswnfHKR/VLk=; b=qZDwMV4crOkitMmF78zyNFVYRJb9e5CEAC4FCpSUWyji9TxxJJgsUSjQudQUxFKjDe OnWpEQMl0la0WRTBE71vLNCTqZ0FYROPkKOith/+dgUtPhzurU8FSu7MZT9BHX5pKJsg Odnw+zIk7XQEqj69zFrjvFnedoTatx8SnUj/qphLqeOX3aUAs9gi9YogmZLEQ0orZMYU BLBhKyWM8Ea3XP+ewS0doz/fBpU9LVhRAnEEs9DKAav5GgWUmOP903EdO9Crdn3c4ag/ kCObtj/qfwF4ndTi6VhjJ56L85HTLk6oryAENEQ7g4+78P1CH5lkHv2JOaOKVsWfptSt rhYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=GL8YlOuK+lPzvntmToerBw7cag+fxZ5AswnfHKR/VLk=; b=psMFDGZW565ssbj3bOQ+JFdvFKUr7HqkyZ421lfytS521iRhfOAeVspsvaFBAXTrX9 u7HPVh2bl3XCeLj2X6TNDlndcJ/QX43XTmU+zoe1yktCAteKgw1uQVJPFSlQK7SThbXs HW1AynyRjszhhlsd389D2kc/5K41/u+v+s5C3ltJJRTitexEA6HKEVtKoniMCPmpvobt 1uliiEacCvB9iSdpqEeqn6oJg46OUUx9b6eET8k/RAfZk/MB4akPs/l1ufnavgPT8U3m rQerABpRuK9uxf4DjTwtEv6Uj4Idlf/1AHmE1PM4IV1rnFjrkOweKU4s8d1ah0zgriBf PVNw== X-Gm-Message-State: APjAAAX4F56u1/I+sdu5IXNBeSzooC0sKjhd297uBQXKLAn7Jo/ADMit JdHbTcdzKv1HdMx9DMmC6irvCUs5 X-Google-Smtp-Source: APXvYqzXvgPJ14PpKCOak++6YdVlnp+Bo55KVfK80pKxm/zXXmnUS0dnTImjZ9kxihgjtrdnQMUchQ== X-Received: by 2002:a1c:dfd6:: with SMTP id w205mr8017311wmg.151.1580422683872; Thu, 30 Jan 2020 14:18:03 -0800 (PST) Received: from [192.168.2.145] (79-139-233-37.dynamic.spd-mgts.ru. [79.139.233.37]) by smtp.googlemail.com with ESMTPSA id y10sm8959076wrw.68.2020.01.30.14.18.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Jan 2020 14:18:03 -0800 (PST) Subject: Re: [Patch v2 0/4] mm/mremap: cleanup move_page_tables() a little To: Wei Yang , akpm@linux-foundation.org, aneesh.kumar@linux.ibm.com, kirill@shutemov.name, dan.j.williams@intel.com, yang.shi@linux.alibaba.com, thellstrom@vmware.com Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20200129002642.13508-1-richardw.yang@linux.intel.com> From: Dmitry Osipenko Message-ID: <50f408bd-502e-bd02-53d4-719300736ce2@gmail.com> Date: Fri, 31 Jan 2020 01:18:00 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0 MIME-Version: 1.0 In-Reply-To: <20200129002642.13508-1-richardw.yang@linux.intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: 29.01.2020 03:26, Wei Yang =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > move_page_tables() tries to move page table by PMD or PTE. >=20 > The root reason is if it tries to move PMD, both old and new range shou= ld > be PMD aligned. But current code calculate old range and new range > separately. This leads to some redundant check and calculation. >=20 > This cleanup tries to consolidate the range check in one place to reduc= e > some extra range handling. >=20 > v2: > * remove 3rd patch which doesn't work on ARM platform. Thanks report = from > Dmitry Osipenko >=20 > Wei Yang (4): > mm/mremap: format the check in move_normal_pmd() same as > move_huge_pmd() > mm/mremap: it is sure to have enough space when extent meets > requirement > mm/mremap: calculate extent in one place > mm/mremap: start addresses are properly aligned >=20 > include/linux/huge_mm.h | 2 +- > mm/huge_memory.c | 8 +------- > mm/mremap.c | 17 ++++++----------- > 3 files changed, 8 insertions(+), 19 deletions(-) >=20 Hello Wei, I haven't noticed any problems using the v2. Thank you very much for addressing the problem! Tested-by: Dmitry Osipenko