From: Glauber Costa <glommer@parallels.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, cgroups@vger.kernel.org,
Michal Hocko <mhocko@suse.cz>,
Kamezawa Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Greg Thelen <gthelen@google.com>, Hugh Dickins <hughd@google.com>,
Ying Han <yinghan@google.com>, Mel Gorman <mgorman@suse.de>,
Rik van Riel <riel@redhat.com>
Subject: Re: [PATCH] memcg: reduce the size of struct memcg 244-fold.
Date: Thu, 24 Jan 2013 10:28:21 +0400 [thread overview]
Message-ID: <5100D485.4020302@parallels.com> (raw)
In-Reply-To: <20130123161810.73e4ca58.akpm@linux-foundation.org>
>> struct mem_cgroup *memcg;
>> - int size = sizeof(struct mem_cgroup);
>> + int size = memcg_size();
>>
>> - /* Can be very big if MAX_NUMNODES is very big */
>> + /* Can be very big if nr_node_ids is very big */
>> if (size < PAGE_SIZE)
>> memcg = kzalloc(size, GFP_KERNEL);
>> else
>> @@ -5933,7 +5943,7 @@ out_free:
>> static void __mem_cgroup_free(struct mem_cgroup *memcg)
>> {
>> int node;
>> - int size = sizeof(struct mem_cgroup);
>> + int size = memcg_size();
>>
>> mem_cgroup_remove_from_trees(memcg);
>> free_css_id(&mem_cgroup_subsys, &memcg->css);
>
> Really everything here should be using size_t - a minor
> cosmetic/readability thing.
>
I agree
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2013-01-24 6:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-23 17:33 [PATCH] memcg: reduce the size of struct memcg 244-fold Glauber Costa
2013-01-24 0:18 ` Andrew Morton
2013-01-24 6:28 ` Glauber Costa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5100D485.4020302@parallels.com \
--to=glommer@parallels.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=gthelen@google.com \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@suse.cz \
--cc=riel@redhat.com \
--cc=yinghan@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).