From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx120.postini.com [74.125.245.120]) by kanga.kvack.org (Postfix) with SMTP id F33E26B0023 for ; Thu, 31 Jan 2013 17:03:20 -0500 (EST) Message-ID: <510AEA20.8040407@zytor.com> Date: Thu, 31 Jan 2013 14:03:12 -0800 From: "H. Peter Anvin" MIME-Version: 1.0 Subject: Re: [RFC][PATCH] rip out x86_32 NUMA remapping code References: <20130131005616.1C79F411@kernel.stglabs.ibm.com> <510AE763.6090907@zytor.com> <510AE92B.8020605@zytor.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Yinghai Lu Cc: Dave Hansen , linux-mm@kvack.org, linux-kernel@vger.kernel.org On 01/31/2013 02:01 PM, Yinghai Lu wrote: > On Thu, Jan 31, 2013 at 1:59 PM, H. Peter Anvin wrote: >> On 01/31/2013 01:55 PM, Yinghai Lu wrote: >>> On Thu, Jan 31, 2013 at 1:51 PM, H. Peter Anvin wrote: >>>> I get a build failure on i386 allyesconfig with this patch: >>>> >>>> arch/x86/power/built-in.o: In function `swsusp_arch_resume': >>>> (.text+0x14e4): undefined reference to `resume_map_numa_kva' >>>> >>>> It looks trivial to fix up; I assume resume_map_numa_kva() just goes >>>> away like it does in the non-NUMA case, but it would be nice if you >>>> could confirm that. >>> >>> the patches does not seem to complete. >>> >>> at least, it does not remove >>> >>> arch/x86/mm/numa.c: nd = alloc_remap(nid, nd_size); >>> >> >> ... which will just return NULL because alloc_remap turns into an inline >> just returning NULL. So the compiled code is correct, but the source >> code is needlessly messy. > > yes... > > It still left #ifdefCONFIG_HAVE_ARCH_ALLOC_REMAP there. > > #ifdef CONFIG_HAVE_ARCH_ALLOC_REMAP > extern void *alloc_remap(int nid, unsigned long size); > #else > static inline void *alloc_remap(int nid, unsigned long size) > { > return NULL; > } > #endif /* CONFIG_HAVE_ARCH_ALLOC_REMAP */ > > should throw them all away. > That is arch-independent code, and the tile architecture still uses it. Makes one wonder how much it will get tested going forward, especially with the x86-32 implementation clearly lacking in that department. -hpa -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org