From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx195.postini.com [74.125.245.195]) by kanga.kvack.org (Postfix) with SMTP id CAFD76B0008 for ; Thu, 21 Feb 2013 14:44:46 -0500 (EST) Message-ID: <512678F9.8020603@synopsys.com> Date: Fri, 22 Feb 2013 01:13:53 +0530 From: Vineet Gupta MIME-Version: 1.0 Subject: Re: [PATCH 1/2] memblock: add assertion for zero allocation size References: <1361471962-25164-1-git-send-email-vgupta@synopsys.com> <1361471962-25164-2-git-send-email-vgupta@synopsys.com> <51267695.8090800@synopsys.com> <20130221193639.GN3570@htj.dyndns.org> In-Reply-To: <20130221193639.GN3570@htj.dyndns.org> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Tejun Heo Cc: Yinghai Lu , "H. Peter Anvin" , Andrew Morton , Chris Zankel , Max Filippov , Marc Gauthier , Wanpeng Li , Ingo Molnar , linux-mm@kvack.org, linux-kernel@vger.kernel.org On Friday 22 February 2013 01:06 AM, Tejun Heo wrote: > On Fri, Feb 22, 2013 at 01:03:41AM +0530, Vineet Gupta wrote: >> Where - you mean if user passes 0, just make it 1. Nah - it's better to complain >> and get the call site fixed ! >> >>> or BUG_ON(!align) instead? >> That could be done too but you would also need BUG_ON(!size) - to catch another >> API abuse. >> BUG_ON(!size) however catches both the cases. > How about "if (WARN_ON(!align)) align = __alignof__(long long);"? > Early BUG_ON()s can be painful to debug depending on setup. Totally agree - been there - seen that :-) Also for caller passing zero, the panic will force the caller to fix it. I'll respin the patch. Thx, -Vineet -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org