From: Seth Jennings <sjenning@linux.vnet.ibm.com>
To: Cody P Schafer <cody@linux.vnet.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Nitin Gupta <ngupta@vflare.org>, Minchan Kim <minchan@kernel.org>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Dan Magenheimer <dan.magenheimer@oracle.com>,
Robert Jennings <rcj@linux.vnet.ibm.com>,
Jenifer Hopper <jhopper@us.ibm.com>, Mel Gorman <mgorman@suse.de>,
Johannes Weiner <jweiner@redhat.com>,
Rik van Riel <riel@redhat.com>,
Larry Woodman <lwoodman@redhat.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Dave Hansen <dave@linux.vnet.ibm.com>,
Joe Perches <joe@perches.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
devel@driverdev.osuosl.org
Subject: Re: [PATCHv6 1/8] zsmalloc: add to mm/
Date: Thu, 21 Feb 2013 16:21:37 -0600 [thread overview]
Message-ID: <51269DF1.9050107@linux.vnet.ibm.com> (raw)
In-Reply-To: <20130221203650.GB3778@negative>
On 02/21/2013 02:36 PM, Cody P Schafer wrote:
> On Wed, Feb 20, 2013 at 04:04:41PM -0600, Seth Jennings wrote:
>> diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
>> +#define MAX(a, b) ((a) >= (b) ? (a) : (b))
>> +/* ZS_MIN_ALLOC_SIZE must be multiple of ZS_ALIGN */
>> +#define ZS_MIN_ALLOC_SIZE \
>> + MAX(32, (ZS_MAX_PAGES_PER_ZSPAGE << PAGE_SHIFT >> OBJ_INDEX_BITS))
>
> Could you use the max(a,b) defined in include/linux/kernel.h?
>
Andrew Morton made the same point. We can't use max() or max_t()
because the value of ZS_MIN_ALLOC_SIZE is used to derive the value of
ZS_SIZE_CLASSES which is used to size an array in struct zs_pool.
So the expression must be completely evaluated to a number by the
precompiler.
Thanks,
Seth
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-02-21 22:39 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-20 22:04 [PATCHv6 0/8] zswap: compressed swap caching Seth Jennings
2013-02-20 22:04 ` [PATCHv6 1/8] zsmalloc: add to mm/ Seth Jennings
2013-02-21 20:36 ` Cody P Schafer
2013-02-21 22:21 ` Seth Jennings [this message]
2013-02-21 22:44 ` Andrew Morton
2013-02-22 9:40 ` Joonsoo Kim
2013-02-22 17:58 ` Seth Jennings
2013-02-20 22:04 ` [PATCHv6 2/8] zsmalloc: add documentation Seth Jennings
2013-02-20 22:04 ` [PATCHv6 3/8] debugfs: add get/set for atomic types Seth Jennings
2013-02-20 22:04 ` [PATCHv6 4/8] zswap: add to mm/ Seth Jennings
2013-02-25 4:35 ` Joonsoo Kim
2013-02-25 17:21 ` Seth Jennings
2013-02-20 22:04 ` [PATCHv6 5/8] mm: break up swap_writepage() for frontswap backends Seth Jennings
2013-02-20 22:04 ` [PATCHv6 6/8] mm: allow for outstanding swap writeback accounting Seth Jennings
2013-02-20 22:04 ` [PATCHv6 7/8] zswap: add swap page writeback support Seth Jennings
2013-02-20 22:04 ` [PATCHv6 8/8] zswap: add documentation Seth Jennings
2013-02-21 15:50 ` [PATCHv6 0/8] zswap: compressed swap caching Dan Magenheimer
2013-02-21 18:25 ` Seth Jennings
2013-02-21 22:03 ` Dan Magenheimer
2013-05-01 8:06 ` Ric Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51269DF1.9050107@linux.vnet.ibm.com \
--to=sjenning@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=cody@linux.vnet.ibm.com \
--cc=dan.magenheimer@oracle.com \
--cc=dave@linux.vnet.ibm.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=jhopper@us.ibm.com \
--cc=joe@perches.com \
--cc=jweiner@redhat.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lwoodman@redhat.com \
--cc=mgorman@suse.de \
--cc=minchan@kernel.org \
--cc=ngupta@vflare.org \
--cc=rcj@linux.vnet.ibm.com \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).