linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Dave Hansen <dave@linux.vnet.ibm.com>
To: Phillip Susi <psusi@ubuntu.com>
Cc: linux-mm@kvack.org
Subject: Re: [PATCH 1/2] mm: fadvise: fix POSIX_FADV_DONTNEED
Date: Sun, 24 Feb 2013 13:25:36 -0800	[thread overview]
Message-ID: <512A8550.2040200@linux.vnet.ibm.com> (raw)
In-Reply-To: <512A7AC4.5000006@ubuntu.com>

On 02/24/2013 12:40 PM, Phillip Susi wrote:
>> > I actually really like the concept behind your patch.  It looks
>> > like very useful functionality.  I'm just saying that I know it
>> > will break _existing_ users.
> I'm not seeing how it will break anything.  Which aspect of the
> current behavior is the app relying on?  If it is the immediate
> removal of clean pages from the cache, then it should not care about
> the new behavior since the pages will still be removed very soon when
> under high cache pressure.

Essentially, they don't want any I/O initiated except that which is
initiated by the app.  If you let the system get in to reclaim, it'll
start doing dirty writeout for pages other than those the app is
interested in.

I'm also not sure how far the "just use O_DIRECT" argument is going to go:

	https://lkml.org/lkml/2007/1/10/233

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2013-02-24 21:25 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-22 19:57 POSIX_FADV_DONTNEED implemented wrong Phillip Susi
2013-02-22 20:29 ` Johannes Weiner
2013-02-22 21:52   ` Phillip Susi
2013-02-23 22:57     ` [PATCH 0/2] FADV_DONTNEED and FADV_NOREUSE Phillip Susi
2013-02-23 22:58     ` [PATCH 1/2] mm: fadvise: fix POSIX_FADV_DONTNEED Phillip Susi
2013-02-24  1:46       ` Dave Hansen
2013-02-24  3:37         ` Phillip Susi
2013-02-24 18:24           ` Dave Hansen
2013-02-24 20:40             ` Phillip Susi
2013-02-24 21:25               ` Dave Hansen [this message]
2013-02-24 22:38                 ` Phillip Susi
2013-02-25 17:50                   ` Dave Hansen
2013-02-24  3:58       ` Zheng Liu
2013-02-24  4:04         ` Phillip Susi
2013-02-26  4:21       ` Minchan Kim
2013-02-26 14:06         ` Andrea Righi
2013-02-26 15:39           ` Phillip Susi
2013-02-23 22:58     ` [PATCH 2/2] mm: fadvise: implement POSIX_FADV_NOREUSE Phillip Susi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=512A8550.2040200@linux.vnet.ibm.com \
    --to=dave@linux.vnet.ibm.com \
    --cc=linux-mm@kvack.org \
    --cc=psusi@ubuntu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).