From: Dave Hansen <dave@linux.vnet.ibm.com>
To: Phillip Susi <psusi@ubuntu.com>
Cc: linux-mm@kvack.org
Subject: Re: [PATCH 1/2] mm: fadvise: fix POSIX_FADV_DONTNEED
Date: Mon, 25 Feb 2013 09:50:21 -0800 [thread overview]
Message-ID: <512BA45D.5040201@linux.vnet.ibm.com> (raw)
In-Reply-To: <512A965A.6060201@ubuntu.com>
On 02/24/2013 02:38 PM, Phillip Susi wrote:
> On 02/24/2013 04:25 PM, Dave Hansen wrote:
>> Essentially, they don't want any I/O initiated except that which
>> is initiated by the app. If you let the system get in to reclaim,
>> it'll start doing dirty writeout for pages other than those the app
>> is interested in.
>
> Are you talking about IO initiated by the app, or other tasks in the
> system? If the former then it won't be affected by this change.
Once we go in to reclaim, we'll start writeback on dirty pages. The
VM's writeback patterns are not as efficient as if the app itself was
initiating them from sync_file_range(), and we see massive throughput
loss on the disk.
>From the looks of your patch, deactivating all the pages (if clean of
course) will get them on the LRU, and should keep any direct-reclaiming
tasks from actually going and initiating any additional I/O.
It looks like a promising approach, at least theoretically. I'll
definitely test and see if it works in practice.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-02-25 17:50 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-22 19:57 POSIX_FADV_DONTNEED implemented wrong Phillip Susi
2013-02-22 20:29 ` Johannes Weiner
2013-02-22 21:52 ` Phillip Susi
2013-02-23 22:57 ` [PATCH 0/2] FADV_DONTNEED and FADV_NOREUSE Phillip Susi
2013-02-23 22:58 ` [PATCH 1/2] mm: fadvise: fix POSIX_FADV_DONTNEED Phillip Susi
2013-02-24 1:46 ` Dave Hansen
2013-02-24 3:37 ` Phillip Susi
2013-02-24 18:24 ` Dave Hansen
2013-02-24 20:40 ` Phillip Susi
2013-02-24 21:25 ` Dave Hansen
2013-02-24 22:38 ` Phillip Susi
2013-02-25 17:50 ` Dave Hansen [this message]
2013-02-24 3:58 ` Zheng Liu
2013-02-24 4:04 ` Phillip Susi
2013-02-26 4:21 ` Minchan Kim
2013-02-26 14:06 ` Andrea Righi
2013-02-26 15:39 ` Phillip Susi
2013-02-23 22:58 ` [PATCH 2/2] mm: fadvise: implement POSIX_FADV_NOREUSE Phillip Susi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=512BA45D.5040201@linux.vnet.ibm.com \
--to=dave@linux.vnet.ibm.com \
--cc=linux-mm@kvack.org \
--cc=psusi@ubuntu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).