From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx205.postini.com [74.125.245.205]) by kanga.kvack.org (Postfix) with SMTP id B35BA6B0005 for ; Sun, 17 Mar 2013 08:58:55 -0400 (EDT) Received: by mail-pb0-f45.google.com with SMTP id ro8so5694154pbb.32 for ; Sun, 17 Mar 2013 05:58:54 -0700 (PDT) Message-ID: <5145BE06.8070309@gmail.com> Date: Sun, 17 Mar 2013 20:58:46 +0800 From: Ric Mason MIME-Version: 1.0 Subject: Re: [PATCH v2 3/4] introduce zero-filled page stat count References: <1363255697-19674-1-git-send-email-liwanp@linux.vnet.ibm.com> <1363255697-19674-4-git-send-email-liwanp@linux.vnet.ibm.com> <20130316130638.GB5987@konrad-lan.dumpdata.com> In-Reply-To: <20130316130638.GB5987@konrad-lan.dumpdata.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Konrad Rzeszutek Wilk Cc: Wanpeng Li , Greg Kroah-Hartman , Andrew Morton , Dan Magenheimer , Seth Jennings , Minchan Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org Hi Konrad, On 03/16/2013 09:06 PM, Konrad Rzeszutek Wilk wrote: > On Thu, Mar 14, 2013 at 06:08:16PM +0800, Wanpeng Li wrote: >> Introduce zero-filled page statistics to monitor the number of >> zero-filled pages. > Hm, you must be using an older version of the driver. Please > rebase it against Greg KH's staging tree. This is where most if not > all of the DebugFS counters got moved to a different file. It seems that zcache debugfs in Greg's staging-next is buggy, Could you test it? > >> Acked-by: Dan Magenheimer >> Signed-off-by: Wanpeng Li >> --- >> drivers/staging/zcache/zcache-main.c | 7 +++++++ >> 1 files changed, 7 insertions(+), 0 deletions(-) >> >> diff --git a/drivers/staging/zcache/zcache-main.c b/drivers/staging/zcache/zcache-main.c >> index db200b4..2091a4d 100644 >> --- a/drivers/staging/zcache/zcache-main.c >> +++ b/drivers/staging/zcache/zcache-main.c >> @@ -196,6 +196,7 @@ static ssize_t zcache_eph_nonactive_puts_ignored; >> static ssize_t zcache_pers_nonactive_puts_ignored; >> static ssize_t zcache_writtenback_pages; >> static ssize_t zcache_outstanding_writeback_pages; >> +static ssize_t zcache_pages_zero; >> >> #ifdef CONFIG_DEBUG_FS >> #include >> @@ -257,6 +258,7 @@ static int zcache_debugfs_init(void) >> zdfs("outstanding_writeback_pages", S_IRUGO, root, >> &zcache_outstanding_writeback_pages); >> zdfs("writtenback_pages", S_IRUGO, root, &zcache_writtenback_pages); >> + zdfs("pages_zero", S_IRUGO, root, &zcache_pages_zero); >> return 0; >> } >> #undef zdebugfs >> @@ -326,6 +328,7 @@ void zcache_dump(void) >> pr_info("zcache: outstanding_writeback_pages=%zd\n", >> zcache_outstanding_writeback_pages); >> pr_info("zcache: writtenback_pages=%zd\n", zcache_writtenback_pages); >> + pr_info("zcache: pages_zero=%zd\n", zcache_pages_zero); >> } >> #endif >> >> @@ -562,6 +565,7 @@ static void *zcache_pampd_eph_create(char *data, size_t size, bool raw, >> kunmap_atomic(user_mem); >> clen = 0; >> zero_filled = true; >> + zcache_pages_zero++; >> goto got_pampd; >> } >> kunmap_atomic(user_mem); >> @@ -645,6 +649,7 @@ static void *zcache_pampd_pers_create(char *data, size_t size, bool raw, >> kunmap_atomic(user_mem); >> clen = 0; >> zero_filled = true; >> + zcache_pages_zero++; >> goto got_pampd; >> } >> kunmap_atomic(user_mem); >> @@ -866,6 +871,7 @@ static int zcache_pampd_get_data_and_free(char *data, size_t *sizep, bool raw, >> zpages = 0; >> if (!raw) >> *sizep = PAGE_SIZE; >> + zcache_pages_zero--; >> goto zero_fill; >> } >> >> @@ -922,6 +928,7 @@ static void zcache_pampd_free(void *pampd, struct tmem_pool *pool, >> zero_filled = true; >> zsize = 0; >> zpages = 0; >> + zcache_pages_zero--; >> } >> >> if (pampd_is_remote(pampd) && !zero_filled) { >> -- >> 1.7.7.6 >> > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: email@kvack.org -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org