From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx113.postini.com [74.125.245.113]) by kanga.kvack.org (Postfix) with SMTP id EF3536B0037 for ; Sun, 24 Mar 2013 08:07:22 -0400 (EDT) Received: by mail-la0-f47.google.com with SMTP id fj20so9601007lab.6 for ; Sun, 24 Mar 2013 05:07:21 -0700 (PDT) Message-ID: <514EEC39.40107@cogentembedded.com> Date: Sun, 24 Mar 2013 16:06:17 +0400 From: Sergei Shtylyov MIME-Version: 1.0 Subject: Re: [RFC PATCH v2, part4 31/39] mm/SH: prepare for removing num_physpages and simplify mem_init() References: <1364109934-7851-1-git-send-email-jiang.liu@huawei.com> <1364109934-7851-54-git-send-email-jiang.liu@huawei.com> In-Reply-To: <1364109934-7851-54-git-send-email-jiang.liu@huawei.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Jiang Liu Cc: Andrew Morton , David Rientjes , Jiang Liu , Wen Congyang , Mel Gorman , Minchan Kim , KAMEZAWA Hiroyuki , Michal Hocko , Jianguo Wu , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Paul Mundt , Tang Chen , linux-sh@vger.kernel.org Hello. On 24-03-2013 11:25, Jiang Liu wrote: > Prepare for removing num_physpages and simplify mem_init(). > Signed-off-by: Jiang Liu > Cc: Paul Mundt > Cc: Wen Congyang > Cc: Tang Chen > Cc: linux-sh@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > --- > arch/sh/mm/init.c | 25 ++++--------------------- > 1 file changed, 4 insertions(+), 21 deletions(-) > diff --git a/arch/sh/mm/init.c b/arch/sh/mm/init.c > index aecd913..3826596 100644 > --- a/arch/sh/mm/init.c > +++ b/arch/sh/mm/init.c > @@ -407,24 +407,18 @@ unsigned int mem_init_done = 0; > > void __init mem_init(void) > { > - int codesize, datasize, initsize; > - int nid; > + pg_data_t *pgdat; > > iommu_init(); > > - num_physpages = 0; > high_memory = NULL; > > - for_each_online_node(nid) { > - pg_data_t *pgdat = NODE_DATA(nid); > + for_each_online_pgdat(pgdat) { > void *node_high_memory; > > - num_physpages += pgdat->node_present_pages; > - > if (pgdat->node_spanned_pages) > free_all_bootmem_node(pgdat); > > - > node_high_memory = (void *)__va((pgdat->node_start_pfn + > pgdat->node_spanned_pages) << > PAGE_SHIFT); > @@ -441,19 +435,8 @@ void __init mem_init(void) > > vsyscall_init(); > > - codesize = (unsigned long) &_etext - (unsigned long) &_text; > - datasize = (unsigned long) &_edata - (unsigned long) &_etext; > - initsize = (unsigned long) &__init_end - (unsigned long) &__init_begin; > - > - printk(KERN_INFO "Memory: %luk/%luk available (%dk kernel code, " > - "%dk data, %dk init)\n", > - nr_free_pages() << (PAGE_SHIFT-10), > - num_physpages << (PAGE_SHIFT-10), > - codesize >> 10, > - datasize >> 10, > - initsize >> 10); > - > - printk(KERN_INFO "virtual kernel memory layout:\n" > + mem_init_print_info(NULL); > + pr_info("virtual kernel memory layout:\n" > " fixmap : 0x%08lx - 0x%08lx (%4ld kB)\n" > #ifdef CONFIG_HIGHMEM > " pkmap : 0x%08lx - 0x%08lx (%4ld kB)\n" > Hm, isn't patch 31 the same as patch 30? WBR, Sergei -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org