Re: [PATCH v3, part4 38/39] mm/hotplug: prepare for removing num_physpages

[Jiang Liu <liuj97@gmail.com>]

On 03/29/2013 07:18 PM, Sam Ravnborg wrote:
> On Tue, Mar 26, 2013 at 11:54:57PM +0800, Jiang Liu wrote:
>> Prepare for removing num_physpages.
>>
>> Signed-off-by: Jiang Liu <jiang.liu@huawei.com>
>> Cc: Wen Congyang <wency@cn.fujitsu.com>
>> Cc: Tang Chen <tangchen@cn.fujitsu.com>
>> Cc: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
>> Cc: linux-mm@kvack.org
>> Cc: linux-kernel@vger.kernel.org
>> ---
>> Hi all,
>> 	Sorry for my mistake that my previous patch series has been screwed up.
>> So I regenerate a third version and also set up a git tree at:
>> 	git://github.com/jiangliu/linux.git mem_init
>> 	Any help to review and test are welcomed!
>>
>> 	Regards!
>> 	Gerry
>> ---
>>  mm/memory_hotplug.c |    4 ----
>>  1 file changed, 4 deletions(-)
>>
>> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
>> index 97454b3..9b1b494 100644
>> --- a/mm/memory_hotplug.c
>> +++ b/mm/memory_hotplug.c
>> @@ -751,10 +751,6 @@ EXPORT_SYMBOL_GPL(restore_online_page_callback);
>>  
>>  void __online_page_set_limits(struct page *page)
>>  {
>> -	unsigned long pfn = page_to_pfn(page);
>> -
>> -	if (pfn >= num_physpages)
>> -		num_physpages = pfn + 1;
>>  }
>>  EXPORT_SYMBOL_GPL(__online_page_set_limits);
> 
> How can this be correct?
> With this change __online_page_set_limits() is now a nop.
Hi Sam,
	We will eventually remove the global variable num_physpages in the last patch.
I kept the nop __online_page_set_limits() because I have a plan to use it to fix other
bugs in memory hotplug, otherwise it may be killed too.
	Regards!
	Gerry

> 
> 	Sam
> 

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>