From: Rik van Riel <riel@redhat.com>
To: Jiang Liu <liuj97@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Jiang Liu <jiang.liu@huawei.com>,
David Rientjes <rientjes@google.com>,
Wen Congyang <wency@cn.fujitsu.com>, Mel Gorman <mgorman@suse.de>,
Minchan Kim <minchan@kernel.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Michal Hocko <mhocko@suse.cz>,
James Bottomley <James.Bottomley@HansenPartnership.com>,
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
David Howells <dhowells@redhat.com>,
Mark Salter <msalter@redhat.com>,
Jianguo Wu <wujianguo@huawei.com>,
linux-mm@kvack.org, linux-arch@vger.kernel.org,
linux-kernel@vger.kernel.org,
Michel Lespinasse <walken@google.com>
Subject: Re: [PATCH v4, part3 11/15] mm: use a dedicated lock to protect totalram_pages and zone->managed_pages
Date: Mon, 08 Apr 2013 09:39:19 -0400 [thread overview]
Message-ID: <5162C887.5070900@redhat.com> (raw)
In-Reply-To: <1365256509-29024-12-git-send-email-jiang.liu@huawei.com>
On 04/06/2013 09:55 AM, Jiang Liu wrote:
> @@ -5186,6 +5189,22 @@ early_param("movablecore", cmdline_parse_movablecore);
>
> #endif /* CONFIG_HAVE_MEMBLOCK_NODE_MAP */
>
> +void adjust_managed_page_count(struct page *page, long count)
> +{
> + bool lock = (system_state != SYSTEM_BOOTING);
> +
> + /* No need to acquire the lock during boot */
> + if (lock)
> + spin_lock(&managed_page_count_lock);
> +
> + page_zone(page)->managed_pages += count;
> + totalram_pages += count;
> +
> + if (lock)
> + spin_unlock(&managed_page_count_lock);
> +}
While I agree the boot code currently does not need the lock, is
there any harm to removing that conditional?
That would simplify the code, and protect against possible future
cleverness of initializing multiple memory things simultaneously.
--
All rights reversed
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-04-08 13:39 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-06 13:54 [PATCH v4, part3 00/15] accurately calculate memory statisitic information Jiang Liu
2013-04-06 13:54 ` [PATCH v4, part3 01/15] mm: fix build warnings caused by free_reserved_area() Jiang Liu
2013-04-19 16:52 ` Russell King - ARM Linux
2013-04-20 15:34 ` Jiang Liu
2013-04-06 13:54 ` [PATCH v4, part3 02/15] mm: enhance free_reserved_area() to support poisoning memory with zero Jiang Liu
2013-04-06 13:54 ` [PATCH v4, part3 03/15] mm/ARM64: kill poison_init_mem() Jiang Liu
2013-04-06 13:54 ` [PATCH v4, part3 04/15] mm/x86: use free_reserved_area() to simplify code Jiang Liu
2013-04-06 13:54 ` [PATCH v4, part3 05/15] mm/tile: use common help functions to free reserved pages Jiang Liu
2013-04-06 13:55 ` [PATCH v4, part3 06/15] mm, powertv: use free_reserved_area() to simplify code Jiang Liu
2013-04-06 13:55 ` [PATCH v4, part3 07/15] mm, acornfb: " Jiang Liu
2013-04-06 13:55 ` [PATCH v4, part3 08/15] mm: fix some trivial typos in comments Jiang Liu
2013-04-06 14:36 ` Sergei Shtylyov
2013-04-06 14:45 ` Jiang Liu
2013-04-06 13:55 ` [PATCH v4, part3 09/15] mm: use managed_pages to calculate default zonelist order Jiang Liu
2013-04-06 13:55 ` [PATCH v4, part3 10/15] mm: accurately calculate zone->managed_pages for highmem zones Jiang Liu
2013-04-06 13:55 ` [PATCH v4, part3 11/15] mm: use a dedicated lock to protect totalram_pages and zone->managed_pages Jiang Liu
2013-04-08 13:39 ` Rik van Riel [this message]
2013-04-08 16:05 ` Jiang Liu
2013-04-06 13:55 ` [PATCH v4, part3 12/15] mm: make __free_pages_bootmem() only available at boot time Jiang Liu
2013-04-06 13:55 ` [PATCH v4, part3 13/15] mm: correctly update zone->mamaged_pages Jiang Liu
2013-04-06 13:55 ` [PATCH v4, part3 14/15] mm: concentrate modification of totalram_pages into the mm core Jiang Liu
2013-04-06 13:55 ` [PATCH v4, part3 15/15] mm: report available pages as "MemTotal" for each NUMA node Jiang Liu
2013-04-07 1:34 ` [PATCH v4, part3 00/15] accurately calculate memory statisitic information Simon Jeons
2013-04-07 15:08 ` Jiang Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5162C887.5070900@redhat.com \
--to=riel@redhat.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=jiang.liu@huawei.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liuj97@gmail.com \
--cc=mgorman@suse.de \
--cc=mhocko@suse.cz \
--cc=minchan@kernel.org \
--cc=msalter@redhat.com \
--cc=rientjes@google.com \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=walken@google.com \
--cc=wency@cn.fujitsu.com \
--cc=wujianguo@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).