From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx155.postini.com [74.125.245.155]) by kanga.kvack.org (Postfix) with SMTP id 248316B0027 for ; Thu, 11 Apr 2013 22:52:09 -0400 (EDT) Message-ID: <516776CD.4070109@redhat.com> Date: Thu, 11 Apr 2013 22:51:57 -0400 From: Rik van Riel MIME-Version: 1.0 Subject: Re: [PATCH 06/10] mm: vmscan: Have kswapd writeback pages based on dirty pages encountered, not priority References: <1365505625-9460-1-git-send-email-mgorman@suse.de> <1365505625-9460-7-git-send-email-mgorman@suse.de> In-Reply-To: <1365505625-9460-7-git-send-email-mgorman@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Mel Gorman Cc: Andrew Morton , Jiri Slaby , Valdis Kletnieks , Zlatko Calusic , Johannes Weiner , dormando , Satoru Moriya , Michal Hocko , Linux-MM , LKML On 04/09/2013 07:07 AM, Mel Gorman wrote: > Currently kswapd queues dirty pages for writeback if scanning at an elevated > priority but the priority kswapd scans at is not related to the number > of unqueued dirty encountered. Since commit "mm: vmscan: Flatten kswapd > priority loop", the priority is related to the size of the LRU and the > zone watermark which is no indication as to whether kswapd should write > pages or not. > > This patch tracks if an excessive number of unqueued dirty pages are being > encountered at the end of the LRU. If so, it indicates that dirty pages > are being recycled before flusher threads can clean them and flags the > zone so that kswapd will start writing pages until the zone is balanced. > > Signed-off-by: Mel Gorman I like your approach of essentially not writing out from kswapd if we manage to reclaim well at DEF_PRIORITY, and doing writeout more and more aggressively if we have to reduce priority. Reviewed-by: Rik van Riel -- All rights reversed -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org