From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx198.postini.com [74.125.245.198]) by kanga.kvack.org (Postfix) with SMTP id 909396B0002 for ; Tue, 16 Apr 2013 11:04:27 -0400 (EDT) Received: by mail-pa0-f44.google.com with SMTP id bi5so395973pad.3 for ; Tue, 16 Apr 2013 08:04:26 -0700 (PDT) Message-ID: <516D6870.1010303@gmail.com> Date: Tue, 16 Apr 2013 23:04:16 +0800 From: Jiang Liu MIME-Version: 1.0 Subject: Re: [RFC PATCH v1 00/19] kill free_all_bootmem() and clean up VALID_PAGE() References: <1365867399-21323-1-git-send-email-jiang.liu@huawei.com> <20130415045614.GB7494@iris.ozlabs.ibm.com> In-Reply-To: <20130415045614.GB7494@iris.ozlabs.ibm.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Paul Mackerras Cc: Andrew Morton , Yinghai Lu , Jiang Liu , David Rientjes , Wen Congyang , Mel Gorman , Minchan Kim , KAMEZAWA Hiroyuki , Michal Hocko , David Howells , Mark Salter , Jianguo Wu , linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org On 04/15/2013 12:56 PM, Paul Mackerras wrote: > On Sat, Apr 13, 2013 at 11:36:20PM +0800, Jiang Liu wrote: >> Commit 600cc5b7f6 "mm: Kill NO_BOOTMEM version free_all_bootmem_node()" >> has kill free_all_bootmem_node() for NO_BOOTMEM. >> >> Currently the usage pattern for free_all_bootmem_node() is like: >> for_each_online_pgdat(pgdat) >> free_all_bootmem_node(pgdat); >> >> It's equivalent to free_all_bootmem(), so this patchset goes one >> step further to kill free_all_bootmem_node() for BOOTMEM too. >> >> This patchset also tries to clean up code and comments related to >> VALID_PAGE() because it has been removed from kernel long time ago. >> >> Patch 1-11: >> Kill free_all_bootmem_node() >> Patch 12-16: >> Clean up code and comments related to VALID_PAGE() >> Patch 17: >> Fix a minor build warning for m68k >> Patch 18: >> merge Alpha's mem_init() for UMA and NUMA. >> Patch 19: >> call register_page_bootmem_info_node() from mm core > > How does this not break bisection? Will a kernel still boot with > patches 1-11 applied but not patch 19? As far as I can see such a > kernel would have no memory available to it after mem_init() time > and would therefore crash early in boot. Hi Paul, Thanks for review! Patch 1-11 replace free_all_bootmem_node() with free_all_bootmem(), so all normal pages will be freed into the buddy system as before. And patch 1-11 are independent with patch 19. Gerry > > Paul. > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org