From: Harry Yoo <harry@kernel.org>
To: Hongling Zeng <zhongling0719@126.com>,
Hongling Zeng <zenghongling@kylinos.cn>,
vbabka@kernel.org, akpm@linux-foundation.org, hao.li@linux.dev,
cl@gentwo.org, rientjes@google.com, roman.gushchin@linux.dev,
vdavydov.dev@gmail.com, davej@fedoraproject.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] mm/slub: add comment explaining intentional kobject handling in sysfs_slab_add
Date: Mon, 13 Jul 2026 17:49:29 +0900 [thread overview]
Message-ID: <516b7984-f4c0-4cf0-bd40-104579950b0a@kernel.org> (raw)
In-Reply-To: <6A549790.3000203@126.com>
[-- Attachment #1.1: Type: text/plain, Size: 1190 bytes --]
On 7/13/26 4:45 PM, Hongling Zeng wrote:
> 在 2026年07月13日 15:26, Harry Yoo 写道:
>> On 7/13/26 4:00 PM, Hongling Zeng wrote:
>>> Add a comment to clarify why we don't call kobject_put() when
>>> kobject_init_and_add() fails in sysfs_slab_add().
>>>
>>> Per commit 2420baa8e046 ("mm/slab: Allow cache creation to proceed
>>> even if sysfs registration fails"), sysfs failures are treated as
>>> non-fatal and the cache continues to be used. Calling kobject_put()
>>> would trigger slab_kmem_cache_release() which frees the entire
>>> cache structure, so we intentionally skip it.
>>>
>>> Suggested-by: Harry Yoo <harry@kernel.org>
>>> Signed-off-by: Hongling Zeng <zenghongling@kylinos.cn>
>>> ---
FWIW, the patch looks fine to me, so:
Acked-by: Harry Yoo (Oracle) <harry@kernel.org>
>>> Change in v1:
>>> -Correct the email
>>
>> Hmm, the email "Hyeonggon Kim <pictureone@kakao.com>" came out of
>> nowhere. Could you please explain why this happened?
> My apologies for the confusion.
>
> I incorrectly retrieved your email from a signature search ：）
You mean retrieved from your local address book?
--
Cheers,
Harry / Hyeonggon
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2026-07-13 8:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-13 7:00 [PATCH v1] mm/slub: add comment explaining intentional kobject handling in sysfs_slab_add Hongling Zeng
2026-07-13 7:26 ` Harry Yoo
2026-07-13 7:45 ` Hongling Zeng
2026-07-13 8:49 ` Harry Yoo [this message]
2026-07-13 13:54 ` Vlastimil Babka (SUSE)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=516b7984-f4c0-4cf0-bd40-104579950b0a@kernel.org \
--to=harry@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=cl@gentwo.org \
--cc=davej@fedoraproject.org \
--cc=hao.li@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=vbabka@kernel.org \
--cc=vdavydov.dev@gmail.com \
--cc=zenghongling@kylinos.cn \
--cc=zhongling0719@126.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox