linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Konstantin Khlebnikov <khlebnikov@openvz.org>
To: Zheng Liu <gnehzuil.liu@gmail.com>
Cc: linux-mm@kvack.org, muming.wq@taobao.com
Subject: Re: [question] call mark_page_accessed() in minor fault
Date: Tue, 23 Apr 2013 17:02:34 +0400	[thread overview]
Message-ID: <5176866A.2060400@openvz.org> (raw)
In-Reply-To: <20130423122542.GA5638@gmail.com>

Zheng Liu wrote:
> Hi all,
>
> Recently we meet a performance regression about mmaped page.  When we upgrade
> our product system from 2.6.18 kernel to a latest kernel, such as 2.6.32 kernel,
> we will find that mmaped pages are reclaimed very quickly.  We found that when
> we hit a minor fault mark_page_accessed() is called in 2.6.18 kernel, but in
> 2.6.32 kernel we don't call mark_page_accesed().  This means that mmaped pages
> in 2.6.18 kernel are activated and moved into active list.  While in 2.6.32
> kernel mmaped pages are still kept in inactive list.
>
> So my question is why we call mark_page_accessed() in 2.6.18 kernel, but don't
> call it in 2.6.32 kernel.  Has any reason here?

Behavior was changed in commit
v2.6.28-6130-gbf3f3bc "mm: don't mark_page_accessed in fault path"

Please see also commits
v3.2-4876-g34dbc67 "vmscan: promote shared file mapped pages" and
v3.2-4877-gc909e99 "vmscan: activate executable pages after first usage".
Probably they can solve some of your problems.

>
> Thanks in advance,
> 						- Zheng
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org.  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email:<a href=mailto:"dont@kvack.org">  email@kvack.org</a>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2013-04-23 13:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-23 12:25 [question] call mark_page_accessed() in minor fault Zheng Liu
2013-04-23 13:02 ` Konstantin Khlebnikov [this message]
2013-04-23 13:49   ` Zheng Liu
2013-04-27  7:10     ` Simon Jeons
2013-04-27  7:55       ` Zheng Liu
2013-04-27  7:40         ` Simon Jeons
2013-04-27 11:14           ` Zheng Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5176866A.2060400@openvz.org \
    --to=khlebnikov@openvz.org \
    --cc=gnehzuil.liu@gmail.com \
    --cc=linux-mm@kvack.org \
    --cc=muming.wq@taobao.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).