Linux-mm Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "David Hildenbrand (Arm)" <david@kernel.org>
To: Joanne Koong <joannelkoong@gmail.com>, Kiryl Shutsemau <kas@kernel.org>
Cc: sashiko-reviews@lists.linux.dev, akpm@linux-foundation.org,
	ljs@kernel.org, baohua@kernel.org, usama.arif@linux.dev,
	hannes@cmpxchg.org, alex@ghiti.fr, ziy@nvidia.com,
	baolin.wang@linux.alibaba.com, liam@infradead.org,
	npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com,
	lance.yang@linux.dev, vbabka@kernel.org, rppt@kernel.org,
	surenb@google.com, mhocko@suse.com, willy@infradead.org,
	linux-mm@kvack.org
Subject: Re: [PATCH v4 4/4] mm: add anonymous mTHP folios to the deferred split list
Date: Tue, 17 Nov 2026 23:14:19 +0100	[thread overview]
Message-ID: <51878e96-c283-4ccb-a06e-4ffe799cb130@kernel.org> (raw)
In-Reply-To: <CAJnrk1YTX=kmDY1zwLncOpzTYsJ9UEa1h1PW9egV59hpnpO=WQ@mail.gmail.com>

On 11/9/26 23:29, Joanne Koong wrote:
> On Thu, Nov 5, 2026 at 4:05 PM Joanne Koong <joannelkoong@gmail.com> wrote:
>>
>> On Thu, Nov 5, 2026 at 4:37 AM Kiryl Shutsemau <kas@kernel.org> wrote:
>>>
>>>
>>> I think it is a bit of understatement.
>>>
>>> For mTHP it is every underused split: the folio is always PTE-mapped and
>>> try_to_migrate_one() drops one PTE at a time. Each underused split bumps
>>> split_deferred for that size next to the new split_underused, and a split
>>> that fails at folio_ref_freeze() leaves a fully mapped folio flagged
>>> partially mapped on the queue, which the next scan splits without
>>> calling thp_underused().
>>>
>>> Can the fix go in before this series? I think it is hard requirement.
>>> Let's not brush if off as pre-existing.
>>>
>>
>> Sounds good, I am looking into this and will submit a fix separately.
> 
> This is the link to the submitted fix:
> https://lore.kernel.org/linux-mm/20261109220958.2071687-1-joannelkoong@gmail.com/
> 
> I'll wait to submit v5 of this series until I've received feedback on that fix.

I assume we can make progress on this even without the other fix in place just yet.

-- 
Cheers,

David


  reply	other threads:[~2026-11-17 22:14 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-03 21:20 [PATCH v4 0/4] mm: split underused anonymous mTHP folios Joanne Koong
2026-11-03 21:20 ` [PATCH v4 1/4] mm/huge_memory: scale thp_underused() to the folio size Joanne Koong
2026-11-05 12:20   ` Kiryl Shutsemau
2026-11-10  3:54   ` Zi Yan
2026-11-12 23:50     ` Joanne Koong
2026-11-10  8:00   ` Baolin Wang
2026-11-17 22:12   ` David Hildenbrand (Arm)
2026-11-03 21:20 ` [PATCH v4 2/4] mm/huge_memory: don't queue folios when underused splitting is inactive Joanne Koong
2026-11-03 22:15   ` Usama Arif
2026-11-05 12:23   ` Kiryl Shutsemau
2026-11-10  8:13   ` Baolin Wang
2026-11-03 21:20 ` [PATCH v4 3/4] mm/huge_memory: add a per-order counter for underused splits Joanne Koong
2026-11-03 22:20   ` Usama Arif
2026-11-05 12:26     ` Kiryl Shutsemau
2026-11-06  0:06       ` Joanne Koong
2026-11-10  8:10   ` Baolin Wang
2026-11-17 22:22   ` David Hildenbrand (Arm)
2026-11-03 21:20 ` [PATCH v4 4/4] mm: add anonymous mTHP folios to the deferred split list Joanne Koong
2026-11-03 22:20   ` Barry Song
2026-11-04 21:21   ` sashiko-bot
2026-11-04 23:50     ` Joanne Koong
2026-11-05 12:37       ` Kiryl Shutsemau
2026-11-06  0:05         ` Joanne Koong
2026-11-09 22:29           ` Joanne Koong
2026-11-17 22:14             ` David Hildenbrand (Arm) [this message]
2026-11-17 22:21   ` David Hildenbrand (Arm)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51878e96-c283-4ccb-a06e-4ffe799cb130@kernel.org \
    --to=david@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=alex@ghiti.fr \
    --cc=baohua@kernel.org \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=dev.jain@arm.com \
    --cc=hannes@cmpxchg.org \
    --cc=joannelkoong@gmail.com \
    --cc=kas@kernel.org \
    --cc=lance.yang@linux.dev \
    --cc=liam@infradead.org \
    --cc=linux-mm@kvack.org \
    --cc=ljs@kernel.org \
    --cc=mhocko@suse.com \
    --cc=npache@redhat.com \
    --cc=rppt@kernel.org \
    --cc=ryan.roberts@arm.com \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=surenb@google.com \
    --cc=usama.arif@linux.dev \
    --cc=vbabka@kernel.org \
    --cc=willy@infradead.org \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox