From: Rik van Riel <riel@redhat.com>
To: Leonid Yegoshin <Leonid.Yegoshin@imgtec.com>
Cc: mhocko@suse.cz, akpm@linux-foundation.org, mgorman@suse.de,
kamezawa.hiroyu@jp.fujitsu.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] COMPACTION: bugfix of improper cache flush in MIGRATION code.
Date: Thu, 09 May 2013 10:38:42 -0400 [thread overview]
Message-ID: <518BB4F2.2040704@redhat.com> (raw)
In-Reply-To: <20130509001821.15951.98705.stgit@linux-yegoshin>
On 05/08/2013 08:18 PM, Leonid Yegoshin wrote:
> Page 'new' during MIGRATION can't be flushed by flush_cache_page().
> Using flush_cache_page(vma, addr, pfn) is justified only if
> page is already placed in process page table, and that is done right
> after flush_cache_page(). But without it the arch function has
> no knowledge of process PTE and does nothing.
>
> Besides that, flush_cache_page() flushes an application cache,
> kernel has a different page virtual address and dirtied it.
>
> Replace it with flush_dcache_page(new) which is a proper usage.
>
> Old page is flushed in try_to_unmap_one() before MIGRATION.
>
> This bug takes place in Sead3 board with M14Kc MIPS CPU without
> cache aliasing (but Harvard arch - separate I and D cache)
> in tight memory environment (128MB) each 1-3days on SOAK test.
> It fails in cc1 during kernel build (SIGILL, SIGBUS, SIGSEG) if
> CONFIG_COMPACTION is switched ON.
Good catch!
> Author: Leonid Yegoshin <yegoshin@mips.com>
> Signed-off-by: Leonid Yegoshin <Leonid.Yegoshin@imgtec.com>
Acked-by: Rik van Riel <riel@redhat.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-05-09 14:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-09 0:18 [PATCH] COMPACTION: bugfix of improper cache flush in MIGRATION code Leonid Yegoshin
2013-05-09 14:38 ` Rik van Riel [this message]
2013-05-10 9:52 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=518BB4F2.2040704@redhat.com \
--to=riel@redhat.com \
--cc=Leonid.Yegoshin@imgtec.com \
--cc=akpm@linux-foundation.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).