From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 123B5C001E0 for ; Mon, 23 Oct 2023 07:05:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 765DC6B00AB; Mon, 23 Oct 2023 03:05:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 716146B00AC; Mon, 23 Oct 2023 03:05:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5B6616B00AD; Mon, 23 Oct 2023 03:05:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 48B5F6B00AB for ; Mon, 23 Oct 2023 03:05:18 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 1D1808092E for ; Mon, 23 Oct 2023 07:05:18 +0000 (UTC) X-FDA: 81375839916.21.C6F1899 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf21.hostedemail.com (Postfix) with ESMTP id E93661C000C for ; Mon, 23 Oct 2023 07:05:15 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XE7vp0G+; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698044716; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oWpylSicIHc7hcbSOmy66rKUIluq26z4Qn2WizKISk4=; b=MRrACsx+ivX9CaFf1cSi7HJ1XFcjh6vNxqFETe8YO5ewapnCcr9bMuXnXNFmvq4AcuA0YQ IwAc5XD5qlJ9cuaQRfMU8KilA3n/VAFDfDf0vlHBA48ilZG2M6XdPSXNiRw8xYmnrtRO9x WG/YFNivJh9UYQAvfQs2N2ESRpTsOAU= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XE7vp0G+; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698044716; a=rsa-sha256; cv=none; b=H8s0dDltPxjpSWoIiz8FC/Ax3bzjG1zKPbUfXGvCvxkzGzfYus7HsELuFBCFqExgp/dl3t 6lMYBhXomja3VSlFbJ4+cM+C4Y+v1xfvLpoLtxOfiEuvmRMVz4hHkN0AZ15TdMvPLeQUIl tj81PUtZ3hc/Az3135VwTTsmiU/ScBU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1698044714; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=oWpylSicIHc7hcbSOmy66rKUIluq26z4Qn2WizKISk4=; b=XE7vp0G+o/wHnF+DozwqUeSC2Fu01M/5rZ6I3LtnnTe81OrNpxpBxaTUnibLEWio4cPwHB mmEiw9GYpItX1XtyhV18XrQYNBqBBjG1apKWQHRl5N0IQwP5kyutBVhAaLEwGYLrnI0sPv tgEa8+ETEFGW883XILwMZAxMeSBD5lo= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-167-CqrZOTo7PZSikN0dVJBReg-1; Mon, 23 Oct 2023 03:05:13 -0400 X-MC-Unique: CqrZOTo7PZSikN0dVJBReg-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-40855a91314so11058745e9.1 for ; Mon, 23 Oct 2023 00:05:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698044711; x=1698649511; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=oWpylSicIHc7hcbSOmy66rKUIluq26z4Qn2WizKISk4=; b=Zb93DWaKy/RboKo4P3fSLLpFM+jhpYXTsE67Ac8THzd4YOzg61iBJRKksvs6CkufZ6 YFbK5vjfrDVMW7WLl9GBNPmwYANgikonSzpkbD/hoZsVCprmnhc4mUN45gbvcsIIHgNk Zn1MPrRbMrqf13GBsV0xZDSLTo2JUBHrvDQovhqAn8SdE83booemJg4SnJHpakFezRNg GbdYYn8v4aV0cZNuVRjIGbrq2pXAJnnOmuVhOS2Lsm87zXxf2x8YzJt4YtJ+x/t/Amjq IB2YcsmZCphDKkZNUQp87Sq0I5CWilvv482eRt+pZJFz3EG+siuBPYvdf14goMwGG0Vy sQcg== X-Gm-Message-State: AOJu0YzhN8C7/Yv6IBYw92rgF/2BP8/sjxOwt2VwDqmtGzRSYzLLt8hc Ca4Nz6sm/9hQ6mNdmSnG0XPLcXyK3eglGLdnW2pj/fQdZ6W+ILJQpsEno6IqR/fpjCEDWdrChVE +bS4fPI6izhQ= X-Received: by 2002:a05:600c:2b10:b0:407:73fc:6818 with SMTP id y16-20020a05600c2b1000b0040773fc6818mr11123729wme.2.1698044710877; Mon, 23 Oct 2023 00:05:10 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEU97bJFCzTaX/NWREVbwAA6qqWQ9i0xT7lseWdSBhsb+qNLBHElkeFAqIEJ7l6y7DLpKX0dw== X-Received: by 2002:a05:600c:2b10:b0:407:73fc:6818 with SMTP id y16-20020a05600c2b1000b0040773fc6818mr11123688wme.2.1698044710296; Mon, 23 Oct 2023 00:05:10 -0700 (PDT) Received: from ?IPV6:2003:cb:c738:1900:b6ea:5b9:62c0:34e? (p200300cbc7381900b6ea05b962c0034e.dip0.t-ipconnect.de. [2003:cb:c738:1900:b6ea:5b9:62c0:34e]) by smtp.gmail.com with ESMTPSA id o15-20020adfcf0f000000b00327de0173f6sm7059882wrj.115.2023.10.23.00.05.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Oct 2023 00:05:09 -0700 (PDT) Message-ID: <5193bc92-a2f5-496d-9625-af6c7be95d99@redhat.com> Date: Mon, 23 Oct 2023 09:05:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/5] mm/khugepaged: Convert is_refcount_suitable() to use folios To: "Vishal Moola (Oracle)" , linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org References: <20231020183331.10770-1-vishal.moola@gmail.com> <20231020183331.10770-4-vishal.moola@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20231020183331.10770-4-vishal.moola@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: E93661C000C X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 4qwki3zdjqazwbu9bwnbkfqyk14pjdkm X-HE-Tag: 1698044715-42251 X-HE-Meta: U2FsdGVkX1++ZE9/lRSFVLlDK6UIaaKfEeIwTdj/j6kejL8hMm+72IpGmDedt0KsnE9b3MNDsqaD4/aRA6xMeI9KqXJ1EhtJMDnSXxiDTMp73RIFmjg3LhAe3kpnYUF7T+IkMfs1pvIUj00gxQjpI1UPmkpvlvMc2ELzziVB9teHt/t1XlN04vIH04wJ31l9aTQK3FlGSTS4wlJnU2SHLSJjqEgHtxByF4Q2FeadIANwqWU6D/wGvV325CQd3Nsvf4xmAtU36r7b3xP08Vo9ZrnjZQuou8hbgr7PclGn5rFmcnm8m2Thv7XwBK0jFz7aAhLtxaZXEmFH9eGvKaTkGzfyjtPNXmBOWaPj+NwXIHWBPlZKSrse6v8ZqZof6k7d8ntOzP8jnWPOLqm1ZzVXTjPU0V9aSGqV+CW1H0zURKoqNmT5shIyVWdNtZCFpFTsMS19UWrMhJyBga59iRA2zOucUW3ZKirt6KkYHo2gD4iNzcvFNyGEdUUSbQsnZhHJ4LEAvAJrjCxtgTAlMKBbXEOiog6u2BRcZfwnGwk21j/kQfjk880YnzLCo4SHuSgVsQvLrmYivx0mvQCGfbKdrE6wKbHVfyrjhY1Spcw2WNfQxpfH1g5QEzyGdVmp8d0tHS8HBgMzyLamMKcIjtr8Kq5WIOCXWwdP7CgUon7B7jQRo6lZLMfDJyzbK7StEPElv0TUQQYkBXdOAnLI410FDy/QkJQzeATkCExbaQol5ZK0nWJFT4bKxrYnv/g1PTXTWpLPr2TXRVa36u+Xl+HyZVxoVPdmkYXYqxtgnD7jYYCK8aXtlutfMlzudq01wvt2tKH84yn5FrNuOXsIaIFzk11TwyShxCtDa/X+YGU24GlsrldnaEfMgAtN+eTg95YLWJO5JTi3LMB84zmIbvsCWHokvJL9zvdndM6/+Hsa3PNOss4m2yOiELQXibKNdib5yNRzzINqzbftip1uROS mxt3TZl0 ArZPlA+nUZWgq27xPiWYymBWqvXSQEGQok1A6qiG5gYk5nrXIHzj/CtEpfJJqJg9JdUHXfoHql056HnIK9t85m6O3CUweRKVK8YAk5LQCFuyEOkIP637lo6zUhipLXwBCAiBxQvPxRtunpLcTNv4Qq0VrUqoIqnvlPNIh81Ug4wUpxDJdPdKqwYD7ickrzfiDSouUAIvUl4IGqlkbFzLuOzQLeaTYwkN/2PR/9Bvz9N0XRtpbBsLTAzESB55MUTW3wQRvrElkGIBoRhXgXmfkU92uoH1dMq6lRjYQu4udUeybwxIgDSJQfFL538eG99WsBRsmd0y3lRU6Y6h027OHnyRmdUUWDyYuYqDnlWdCyKgNTsp0mqgVa68+Ek8lgAVeHmqL7SuI4ZLXK3lmol62+Xe4Gc8zgi+2ZQ+f0HuJlNdCWA/tOTwW19QG5DDAkjml/n3HIuBRDHsGMt2RYXccDO43YenO54uvmzuFPWF4zGGXTf5NYG64B6+C1MmiO3DbE0tnABdhoqPMEapZGuMBe9aKHsBx7F7hoXPvZeN17gXQfvDJ9+Yw6UEFLyK/5AkiC8DMTYJnx/+4asA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 20.10.23 20:33, Vishal Moola (Oracle) wrote: > Both callers of is_refcount_suitable() have been converted to use > folios, so convert it to take in a folio. Both callers only operate on > head pages of folios so mapcount/refcount conversions here are trivial. > > Removes 3 calls to compound head, and removes 315 bytes of kernel text. > > Signed-off-by: Vishal Moola (Oracle) > --- > mm/khugepaged.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/mm/khugepaged.c b/mm/khugepaged.c > index 6c4b5af43371..9efd8ff68f06 100644 > --- a/mm/khugepaged.c > +++ b/mm/khugepaged.c > @@ -524,15 +524,15 @@ static void release_pte_pages(pte_t *pte, pte_t *_pte, > } > } > > -static bool is_refcount_suitable(struct page *page) > +static bool is_refcount_suitable(struct folio *folio) > { > int expected_refcount; > > - expected_refcount = total_mapcount(page); > - if (PageSwapCache(page)) > - expected_refcount += compound_nr(page); > + expected_refcount = folio_mapcount(folio); > + if (folio_test_swapcache(folio)) > + expected_refcount += folio_nr_pages(folio); > > - return page_count(page) == expected_refcount; > + return folio_ref_count(folio) == expected_refcount; > } > > static int __collapse_huge_page_isolate(struct vm_area_struct *vma, > @@ -625,7 +625,7 @@ static int __collapse_huge_page_isolate(struct vm_area_struct *vma, > * but not from this process. The other process cannot write to > * the page, only trigger CoW. > */ > - if (!is_refcount_suitable(&folio->page)) { > + if (!is_refcount_suitable(folio)) { > folio_unlock(folio); > result = SCAN_PAGE_COUNT; > goto out; > @@ -1371,7 +1371,7 @@ static int hpage_collapse_scan_pmd(struct mm_struct *mm, > * has excessive GUP pins (i.e. 512). Anyway the same check > * will be done again later the risk seems low. > */ > - if (!is_refcount_suitable(&folio->page)) { > + if (!is_refcount_suitable(folio)) { > result = SCAN_PAGE_COUNT; > goto out_unmap; > } Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb