From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx182.postini.com [74.125.245.182]) by kanga.kvack.org (Postfix) with SMTP id 967776B0002 for ; Tue, 21 May 2013 15:32:48 -0400 (EDT) Message-ID: <519BCBDE.2050504@intel.com> Date: Tue, 21 May 2013 12:32:46 -0700 From: Dave Hansen MIME-Version: 1.0 Subject: Re: [PATCHv4 10/39] thp: account anon transparent huge pages into NR_ANON_PAGES References: <1368321816-17719-1-git-send-email-kirill.shutemov@linux.intel.com> <1368321816-17719-11-git-send-email-kirill.shutemov@linux.intel.com> In-Reply-To: <1368321816-17719-11-git-send-email-kirill.shutemov@linux.intel.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: "Kirill A. Shutemov" Cc: Andrea Arcangeli , Andrew Morton , Al Viro , Hugh Dickins , Wu Fengguang , Jan Kara , Mel Gorman , linux-mm@kvack.org, Andi Kleen , Matthew Wilcox , "Kirill A. Shutemov" , Hillf Danton , Dave Hansen , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org On 05/11/2013 06:23 PM, Kirill A. Shutemov wrote: > From: "Kirill A. Shutemov" > > We use NR_ANON_PAGES as base for reporting AnonPages to user. > There's not much sense in not accounting transparent huge pages there, but > add them on printing to user. > > Let's account transparent huge pages in NR_ANON_PAGES in the first place. This is another one that needs to be pretty carefully considered _independently_ of the rest of this set. It also has potential user-visible changes, so it would be nice to have a blurb in the patch description if you've thought about this, any why you think it's OK. But, it still makes solid sense to me, and simplifies the code. Acked-by: Dave Hansen -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org