From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx141.postini.com [74.125.245.141]) by kanga.kvack.org (Postfix) with SMTP id 4EF146B0037 for ; Sat, 25 May 2013 21:16:28 -0400 (EDT) Received: by mail-vb0-f44.google.com with SMTP id i3so2170926vbh.17 for ; Sat, 25 May 2013 18:16:27 -0700 (PDT) Message-ID: <51A16268.4000401@gmail.com> Date: Sat, 25 May 2013 21:16:24 -0400 From: KOSAKI Motohiro MIME-Version: 1.0 Subject: Re: [PATCH v2 1/4] mm/memory-hotplug: fix lowmem count overflow when offline pages References: <1369298568-20094-1-git-send-email-liwanp@linux.vnet.ibm.com> In-Reply-To: <1369298568-20094-1-git-send-email-liwanp@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Wanpeng Li Cc: Andrew Morton , Michal Hocko , KAMEZAWA Hiroyuki , David Rientjes , Jiang Liu , Tang Chen , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Benjamin Herrenschmidt , kosaki.motohiro@gmail.com > --- > mm/page_alloc.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 98cbdf6..23b921f 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -6140,6 +6140,8 @@ __offline_isolated_pages(unsigned long start_pfn, unsigned long end_pfn) > list_del(&page->lru); > rmv_page_order(page); > zone->free_area[order].nr_free--; > + if (PageHighMem(page)) > + totalhigh_pages -= 1 << order; > for (i = 0; i < (1 << order); i++) > SetPageReserved((page+i)); > pfn += (1 << order); memory hotplug don't support 32bit since it was born, at least, when the system has highmem. Why can't we disable memory hotremove when 32bit at compile time? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org