Re: [PATCH v2 1/4] mm/memory-hotplug: fix lowmem count overflow when offline pages

[KOSAKI Motohiro <kosaki.motohiro@gmail.com>]

(5/25/13 9:23 PM), Wanpeng Li wrote:
> Hi KOSAKI,
> On Sat, May 25, 2013 at 09:16:24PM -0400, KOSAKI Motohiro wrote:
>>> ---
>>>  mm/page_alloc.c | 2 ++
>>>  1 file changed, 2 insertions(+)
>>>
>>> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
>>> index 98cbdf6..23b921f 100644
>>> --- a/mm/page_alloc.c
>>> +++ b/mm/page_alloc.c
>>> @@ -6140,6 +6140,8 @@ __offline_isolated_pages(unsigned long start_pfn, unsigned long end_pfn)
>>>  		list_del(&page->lru);
>>>  		rmv_page_order(page);
>>>  		zone->free_area[order].nr_free--;
>>> +		if (PageHighMem(page))
>>> +			totalhigh_pages -= 1 << order;
>>>  		for (i = 0; i < (1 << order); i++)
>>>  			SetPageReserved((page+i));
>>>  		pfn += (1 << order);
>>
>> memory hotplug don't support 32bit since it was born, at least, when the system has highmem. 
>> Why can't we disable memory hotremove when 32bit at compile time?
> 
> Here is logic memory remove instead of ACPI based memory remove. ;-)

I know.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>