From: Hush Bensen <hush.bensen@gmail.com>
To: KOSAKI Motohiro <kosaki.motohiro@gmail.com>,
Michal Hocko <mhocko@suse.cz>
Cc: Wanpeng Li <liwanp@linux.vnet.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
David Rientjes <rientjes@google.com>,
Jiang Liu <jiang.liu@huawei.com>,
Tang Chen <tangchen@cn.fujitsu.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
stable@vger.kernel.org
Subject: Re: [patch v2 3/6] mm/memory_hotplug: Disable memory hotremove for 32bit
Date: Sun, 26 May 2013 20:45:08 +0800 [thread overview]
Message-ID: <51A203D4.6080001@gmail.com> (raw)
In-Reply-To: <CAHGf_=otK_LNgd6S09Fjjo0PfTSF3X0kj+=kGNyaTAze7m-b8w@mail.gmail.com>
ao? 2013/5/26 19:58, KOSAKI Motohiro a??e??:
>>> As KOSAKI Motohiro mentioned, memory hotplug don't support 32bit since
>>> it was born,
>> Why? any reference? This reasoning is really weak.
> I have no seen any highmem support in memory hotplug code and I don't think this
> patch fixes all 32bit highmem issue. If anybody are interesting to
> support it, it is good thing. But in fact, _now_ it is broken when
> enable HIGHMEM.
But online/offline memory can work well when enable HIGHMEM, isn't it?
> So, I just want to mark broken until someone want to support highmem
> and verify overall.
>
> And, yes, this patch is no good. Kconfig doesn't describe why disable
> when highmem.
> So,
>
> depends on 64BIT || !HIGHMEM || BROKEN
>
> maybe clear documentation more.
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org. For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-05-26 12:45 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-26 5:58 [PATCH v3 1/6] mm/memory-hotplug: fix lowmem count overflow when offline pages Wanpeng Li
2013-05-26 5:58 ` [PATCH v3 2/6] mm/memory_hotplug: remove memory_add_physaddr_to_nid Wanpeng Li
2013-05-26 8:59 ` Michal Hocko
2013-05-26 9:03 ` Wanpeng Li
2013-05-26 9:03 ` Wanpeng Li
2013-05-26 5:58 ` [patch v2 3/6] mm/memory_hotplug: Disable memory hotremove for 32bit Wanpeng Li
2013-05-26 9:00 ` Michal Hocko
2013-05-26 9:06 ` Wanpeng Li
2013-05-26 9:06 ` Wanpeng Li
2013-05-26 18:12 ` Michal Hocko
2013-05-26 23:51 ` Wanpeng Li
2013-05-27 6:48 ` Michal Hocko
2013-05-27 7:00 ` Wanpeng Li
2013-05-27 7:00 ` Wanpeng Li
2013-05-26 23:51 ` Wanpeng Li
2013-05-26 11:58 ` KOSAKI Motohiro
2013-05-26 12:45 ` Hush Bensen [this message]
2013-05-26 13:06 ` KOSAKI Motohiro
2013-05-26 13:49 ` Hush Bensen
2013-05-26 18:09 ` Michal Hocko
2013-05-26 22:02 ` KOSAKI Motohiro
2013-05-26 5:58 ` [PATCH v3 4/6] mm/hugetlb: use already exist interface huge_page_shift Wanpeng Li
2013-05-26 5:58 ` [PATCH v3 5/6] mm/pageblock: remove get/set_pageblock_flags Wanpeng Li
2013-05-26 5:58 ` [PATCH v3 6/6] mm/hugetlb: remove hugetlb_prefault Wanpeng Li
2013-05-26 11:49 ` [PATCH v3 1/6] mm/memory-hotplug: fix lowmem count overflow when offline pages KOSAKI Motohiro
2013-05-27 0:02 ` Wanpeng Li
2013-05-27 0:02 ` Wanpeng Li
[not found] ` <51a2a2ab.a2f6420a.33bb.ffffda23SMTPIN_ADDED_BROKEN@mx.google.com>
2013-05-27 6:42 ` KOSAKI Motohiro
2013-05-26 14:26 ` Liu Jiang
2013-05-26 23:44 ` Wanpeng Li
2013-05-26 23:44 ` Wanpeng Li
2013-05-28 3:37 ` Ben Hutchings
2013-05-28 7:16 ` Wanpeng Li
2013-05-28 7:16 ` Wanpeng Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51A203D4.6080001@gmail.com \
--to=hush.bensen@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=jiang.liu@huawei.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kosaki.motohiro@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liwanp@linux.vnet.ibm.com \
--cc=mhocko@suse.cz \
--cc=rientjes@google.com \
--cc=stable@vger.kernel.org \
--cc=tangchen@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).