From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx203.postini.com [74.125.245.203]) by kanga.kvack.org (Postfix) with SMTP id C82926B009A for ; Sun, 26 May 2013 08:45:16 -0400 (EDT) Received: by mail-pa0-f42.google.com with SMTP id bj1so670568pad.1 for ; Sun, 26 May 2013 05:45:16 -0700 (PDT) Message-ID: <51A203D4.6080001@gmail.com> Date: Sun, 26 May 2013 20:45:08 +0800 From: Hush Bensen MIME-Version: 1.0 Subject: Re: [patch v2 3/6] mm/memory_hotplug: Disable memory hotremove for 32bit References: <1369547921-24264-1-git-send-email-liwanp@linux.vnet.ibm.com> <1369547921-24264-3-git-send-email-liwanp@linux.vnet.ibm.com> <20130526090054.GE10651@dhcp22.suse.cz> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: owner-linux-mm@kvack.org List-ID: To: KOSAKI Motohiro , Michal Hocko Cc: Wanpeng Li , Andrew Morton , KAMEZAWA Hiroyuki , David Rientjes , Jiang Liu , Tang Chen , "linux-mm@kvack.org" , LKML , Greg Kroah-Hartman , stable@vger.kernel.org ao? 2013/5/26 19:58, KOSAKI Motohiro a??e??: >>> As KOSAKI Motohiro mentioned, memory hotplug don't support 32bit since >>> it was born, >> Why? any reference? This reasoning is really weak. > I have no seen any highmem support in memory hotplug code and I don't think this > patch fixes all 32bit highmem issue. If anybody are interesting to > support it, it is good thing. But in fact, _now_ it is broken when > enable HIGHMEM. But online/offline memory can work well when enable HIGHMEM, isn't it? > So, I just want to mark broken until someone want to support highmem > and verify overall. > > And, yes, this patch is no good. Kconfig doesn't describe why disable > when highmem. > So, > > depends on 64BIT || !HIGHMEM || BROKEN > > maybe clear documentation more. > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: email@kvack.org -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org