From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx168.postini.com [74.125.245.168]) by kanga.kvack.org (Postfix) with SMTP id 32A316B0106 for ; Mon, 27 May 2013 09:57:13 -0400 (EDT) Received: by mail-lb0-f177.google.com with SMTP id o10so6651208lbi.8 for ; Mon, 27 May 2013 06:57:11 -0700 (PDT) Message-ID: <51A36633.2030905@cogentembedded.com> Date: Mon, 27 May 2013 17:57:07 +0400 From: Sergei Shtylyov MIME-Version: 1.0 Subject: Re: [PATCH v8, part3 12/14] mm: correctly update zone->mamaged_pages References: <1369575522-26405-1-git-send-email-jiang.liu@huawei.com> <1369575522-26405-13-git-send-email-jiang.liu@huawei.com> In-Reply-To: <1369575522-26405-13-git-send-email-jiang.liu@huawei.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Jiang Liu Cc: Andrew Morton , Jiang Liu , David Rientjes , Wen Congyang , Mel Gorman , Minchan Kim , KAMEZAWA Hiroyuki , Michal Hocko , James Bottomley , David Howells , Mark Salter , Jianguo Wu , linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Chris Metcalf , Rusty Russell , "Michael S. Tsirkin" , Konrad Rzeszutek Wilk , Jeremy Fitzhardinge , Tang Chen , Yasuaki Ishimatsu , virtualization@lists.linux-foundation.org, xen-devel@lists.xensource.com On 26-05-2013 17:38, Jiang Liu wrote: Typo in the subject: s/mamaged_pages/managed_pages/. > Enhance adjust_managed_page_count() to adjust totalhigh_pages for > highmem pages. And change code which directly adjusts totalram_pages > to use adjust_managed_page_count() because it adjusts totalram_pages, > totalhigh_pages and zone->managed_pages altogether in a safe way. > Remove inc_totalhigh_pages() and dec_totalhigh_pages() from xen/balloon > driver bacause adjust_managed_page_count() has already adjusted > totalhigh_pages. > This patch also fixes two bugs: > 1) enhances virtio_balloon driver to adjust totalhigh_pages when > reserve/unreserve pages. > 2) enhance memory_hotplug.c to adjust totalhigh_pages when hot-removing > memory. > We still need to deal with modifications of totalram_pages in file > arch/powerpc/platforms/pseries/cmm.c, but need help from PPC experts. > Signed-off-by: Jiang Liu > Cc: Chris Metcalf > Cc: Rusty Russell > Cc: "Michael S. Tsirkin" > Cc: Konrad Rzeszutek Wilk > Cc: Jeremy Fitzhardinge > Cc: Wen Congyang > Cc: Andrew Morton > Cc: Tang Chen > Cc: Yasuaki Ishimatsu > Cc: Mel Gorman > Cc: Minchan Kim > Cc: linux-kernel@vger.kernel.org > Cc: virtualization@lists.linux-foundation.org > Cc: xen-devel@lists.xensource.com > Cc: linux-mm@kvack.org > --- > drivers/virtio/virtio_balloon.c | 8 +++++--- > drivers/xen/balloon.c | 23 +++++------------------ > mm/hugetlb.c | 2 +- > mm/memory_hotplug.c | 16 +++------------- > mm/page_alloc.c | 10 +++++----- > 5 files changed, 19 insertions(+), 40 deletions(-) > diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c > index bd3ae32..6649968 100644 > --- a/drivers/virtio/virtio_balloon.c > +++ b/drivers/virtio/virtio_balloon.c [...] > @@ -160,11 +160,13 @@ static void fill_balloon(struct virtio_balloon *vb, size_t num) > static void release_pages_by_pfn(const u32 pfns[], unsigned int num) > { > unsigned int i; > + struct page *page; Why not declare it right in the *for* loop? You could use intializer then... > > /* Find pfns pointing at start of each page, get pages and free them. */ > for (i = 0; i < num; i += VIRTIO_BALLOON_PAGES_PER_PAGE) { > - balloon_page_free(balloon_pfn_to_page(pfns[i])); > - totalram_pages++; > + page = balloon_pfn_to_page(pfns[i]); > + balloon_page_free(page); > + adjust_managed_page_count(page, 1); > } > } > [...] WBR, Sergei -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org