From: Dave Hansen <dave.hansen@intel.com>
To: Cody P Schafer <cody@linux.vnet.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
Linux MM <linux-mm@kvack.org>
Subject: Re: [PATCH] mm: sparse: use __aligned() instead of manual padding in mem_section
Date: Thu, 30 May 2013 10:39:16 -0700 [thread overview]
Message-ID: <51A78EC4.4080703@intel.com> (raw)
In-Reply-To: <1369869279-20155-1-git-send-email-cody@linux.vnet.ibm.com>
On 05/29/2013 04:14 PM, Cody P Schafer wrote:
> Instead of leaving a trap for the next person who comes along and wants
> to add something to mem_section, add an __aligned() and remove the
> manual padding added for MEMCG.
It doesn't need to be aligned technically. It needs to be a power-of-2:
http://lkml.indiana.edu/hypermail/linux/kernel/1205.2/03077.html
I'd be quite happy for someone to resurrect that patch, though. We need
a big fat comment in there.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-05-30 17:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-29 23:14 [PATCH] mm: sparse: use __aligned() instead of manual padding in mem_section Cody P Schafer
2013-05-30 0:54 ` Jiang Liu
2013-05-30 16:36 ` Cody P Schafer
2013-05-30 17:39 ` Dave Hansen [this message]
2013-05-30 18:40 ` [PATCH] sparsemem: BUILD_BUG_ON when sizeof mem_section is non-power-of-2 Cody P Schafer
2013-05-30 19:18 ` Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51A78EC4.4080703@intel.com \
--to=dave.hansen@intel.com \
--cc=akpm@linux-foundation.org \
--cc=cody@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).