From: Laura Abbott <lauraa@codeaurora.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Kyungmin Park <kmpark@infradead.org>,
Tomasz Stanislawski <t.stanislaws@samsung.com>,
linux-mm@kvack.org, Marek Szyprowski <m.szyprowski@samsung.com>,
minchan@kernel.org, mgorman@suse.de,
'Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: Re: [PATCH] mm: page_alloc: fix watermark check in __zone_watermark_ok()
Date: Mon, 03 Jun 2013 19:34:57 -0700 [thread overview]
Message-ID: <51AD5251.9020202@codeaurora.org> (raw)
In-Reply-To: <20130529150811.3d4d9a55f704e95be64c7b52@linux-foundation.org>
On 5/29/2013 3:08 PM, Andrew Morton wrote:
> On Sat, 25 May 2013 13:32:02 +0900 Kyungmin Park <kmpark@infradead.org> wrote:
>
>>> I haven't seen any response to this patch but it has been of some benefit
>>> to some of our use cases. You're welcome to add
>>>
>>> Tested-by: Laura Abbott <lauraa@codeaurora.org>
>>>
>>
>> Thanks Laura,
>> We already got mail from Andrew, it's merged mm tree.
>
> Yes, but I have it scheduled for 3.11 with no -stable backport.
>
> This is because the patch changelog didn't tell me about the
> userspace-visible impact of the bug. Judging from Laura's comments, this
> was a mistake.
>
> So please: details. What problems were observable to Laura and do we
> think this bug should be fixed in 3.10 and earlier?
>
We were observing allocation failures of higher order pages (order 5 =
128K typically) under tight memory conditions resulting in driver
failure. The output from the page allocation failure showed plenty of
free pages of the appropriate order/type/zone and mostly CMA pages in
the lower orders.
For full disclosure, we still observed some page allocation failures
even after applying the patch but the number was drastically reduced and
those failures were attributed to fragmentation/other system issues.
Thanks,
Laura
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-06-04 2:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-09 7:50 [PATCH] mm: page_alloc: fix watermark check in __zone_watermark_ok() Tomasz Stanislawski
2013-05-24 20:23 ` Laura Abbott
2013-05-25 4:32 ` Kyungmin Park
2013-05-29 22:08 ` Andrew Morton
2013-06-03 7:15 ` Marek Szyprowski
2013-06-04 2:34 ` Laura Abbott [this message]
2013-06-04 7:11 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51AD5251.9020202@codeaurora.org \
--to=lauraa@codeaurora.org \
--cc=akpm@linux-foundation.org \
--cc=b.zolnierkie@samsung.com \
--cc=kmpark@infradead.org \
--cc=linux-mm@kvack.org \
--cc=m.szyprowski@samsung.com \
--cc=mgorman@suse.de \
--cc=minchan@kernel.org \
--cc=t.stanislaws@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).