From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx125.postini.com [74.125.245.125]) by kanga.kvack.org (Postfix) with SMTP id 8E2636B0031 for ; Thu, 6 Jun 2013 07:46:43 -0400 (EDT) Message-ID: <51B076D1.20007@parallels.com> Date: Thu, 6 Jun 2013 15:47:29 +0400 From: Glauber Costa MIME-Version: 1.0 Subject: Re: [PATCH v10 08/35] list: add a new LRU list type References: <1370287804-3481-1-git-send-email-glommer@openvz.org> <1370287804-3481-9-git-send-email-glommer@openvz.org> <20130605160758.19e854a6995e3c2a1f5260bf@linux-foundation.org> <20130606024909.GP29338@dastard> <20130605200554.d4dae16f.akpm@linux-foundation.org> <20130606044426.GX29338@dastard> <20130606000409.e4333f7c.akpm@linux-foundation.org> <51B05069.5070404@parallels.com> <20130606025517.8400c279.akpm@linux-foundation.org> In-Reply-To: <20130606025517.8400c279.akpm@linux-foundation.org> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Andrew Morton Cc: Dave Chinner , Glauber Costa , linux-fsdevel@vger.kernel.org, Mel Gorman , linux-mm@kvack.org, cgroups@vger.kernel.org, kamezawa.hiroyu@jp.fujitsu.com, Michal Hocko , Johannes Weiner , hughd@google.com, Greg Thelen , Dave Chinner On 06/06/2013 01:55 PM, Andrew Morton wrote: > On Thu, 6 Jun 2013 13:03:37 +0400 Glauber Costa wrote: > >> I do think it would be more appropriate to >>> discard the lib/ idea and move it all into fs/ or mm/. >> I have no particular love for this in lib/ >> >> Most of the users are in fs/, so I see no point in mm/ >> So for me, if you are really not happy about lib, I would suggest moving >> this to fs/ > > Always feel free to differ but yes, fs/ seems better to me. > > I suggested mm/ also because that's where the shrinker core resides. > As I said, unless Dave has a strong point against it, I don't really care if it lives in lib/ or not. It is infrastructure, but not necessarily lib-like infrastructure. Now, I have been thinking about this during the last hour, and as much as all users are in fs/, putting it into mm/ would give us quite some other advantage: namely, it has been already detected that we would like to have, if possible, stronger ties between shrinkers, caches and the underlying lists. We use a bunch of mm/ infrastructure, etc. This is always something we can change if it really hurts, but right now I am 51 % mm/ 49 % fs/ -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org