From: Cody P Schafer <cody@linux.vnet.ibm.com>
To: David Rientjes <rientjes@google.com>
Cc: "Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linux MM <linux-mm@kvack.org>
Subject: Re: [PATCH] mm/page_alloc: remove repetitious local_irq_save() in __zone_pcp_update()
Date: Wed, 19 Jun 2013 16:06:00 -0700 [thread overview]
Message-ID: <51C23958.9020108@linux.vnet.ibm.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1306191543070.15308@chino.kir.corp.google.com>
On 06/19/2013 03:53 PM, David Rientjes wrote:
> On Wed, 19 Jun 2013, Srivatsa S. Bhat wrote:
>
>>> __zone_pcp_update() is called via stop_machine(), which already disables
>>> local irq.
>>>
>>> mm/page_alloc.c | 4 +---
>>> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> This seems like a fine cleanup because stop_machine() disable irqs, but it
> appears like there is two problems with this function already:
>
Re-examining this, I've realized that my previous patchset containing
"mm/page_alloc: convert zone_pcp_update() to rely on memory barriers
instead of stop_machine()"
already went through and fixed this up (the right way). So ignore this
patch.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-06-19 23:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-18 22:10 [PATCH] mm/page_alloc: remove repetitious local_irq_save() in __zone_pcp_update() Cody P Schafer
2013-06-19 9:15 ` Srivatsa S. Bhat
2013-06-19 22:53 ` David Rientjes
2013-06-19 23:06 ` Cody P Schafer [this message]
2013-06-19 23:17 ` David Rientjes
2013-06-19 23:21 ` Cody P Schafer
2013-06-20 6:32 ` Srivatsa S. Bhat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51C23958.9020108@linux.vnet.ibm.com \
--to=cody@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
--cc=srivatsa.bhat@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).