From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx206.postini.com [74.125.245.206]) by kanga.kvack.org (Postfix) with SMTP id E66D06B0034 for ; Mon, 8 Jul 2013 04:03:57 -0400 (EDT) Received: by mail-la0-f47.google.com with SMTP id fe20so3460219lab.6 for ; Mon, 08 Jul 2013 01:03:56 -0700 (PDT) Message-ID: <51DA726A.8090108@kernel.org> Date: Mon, 08 Jul 2013 11:03:54 +0300 From: Pekka Enberg MIME-Version: 1.0 Subject: Re: [PATCH 2/3] mm/slab: Sharing s_next and s_stop between slab and slub References: <1372069394-26167-1-git-send-email-liwanp@linux.vnet.ibm.com> <1372069394-26167-2-git-send-email-liwanp@linux.vnet.ibm.com> <0000013f9aeb70c6-f6dad22c-bb88-4313-8602-538a3f5cedf5-000000@email.amazonses.com> <20130708001644.GA18895@hacker.(null)> In-Reply-To: <20130708001644.GA18895@hacker.(null)> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Wanpeng Li Cc: Christoph Lameter , Matt Mackall , Glauber Costa , Andrew Morton , Joonsoo Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org On 07/08/2013 03:16 AM, Wanpeng Li wrote: > On Sun, Jul 07, 2013 at 07:41:54PM +0300, Pekka Enberg wrote: >> On Mon, Jul 1, 2013 at 6:48 PM, Christoph Lameter wrote: >>> On Mon, 24 Jun 2013, David Rientjes wrote: >>> >>>> On Mon, 24 Jun 2013, Wanpeng Li wrote: >>>> >>>>> This patch shares s_next and s_stop between slab and slub. >>>>> >>>> >>>> Just about the entire kernel includes slab.h, so I think you'll need to >>>> give these slab-specific names instead of exporting "s_next" and "s_stop" >>>> to everybody. >>> >>> He put the export into mm/slab.h. The headerfile is only included by >>> mm/sl?b.c . >> >> But he then went on to add globally visible symbols "s_next" and >> "s_stop" which is bad... >> >> Please send me an incremental patch on top of slab/next to fix this >> up. Otherwise I'll revert it before sending a pull request to Linus. > > I attach the incremental patch in attachment. ;-) Applied, thanks! Pekka -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org