From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx177.postini.com [74.125.245.177]) by kanga.kvack.org (Postfix) with SMTP id A94156B004D for ; Thu, 11 Jul 2013 11:45:29 -0400 (EDT) Message-ID: <51DED313.6050900@intel.com> Date: Thu, 11 Jul 2013 08:45:23 -0700 From: Dave Hansen MIME-Version: 1.0 Subject: Re: [-] drop_caches-add-some-documentation-and-info-messsge.patch removed from -mm tree References: <51ddc31f.zotz9WDKK3lWXtDE%akpm@linux-foundation.org> <20130711073644.GB21667@dhcp22.suse.cz> <20130711123903.GF21667@dhcp22.suse.cz> <51DED095.7050803@intel.com> <20130711154249.GL21667@dhcp22.suse.cz> In-Reply-To: <20130711154249.GL21667@dhcp22.suse.cz> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Michal Hocko Cc: akpm@linux-foundation.org, kosaki.motohiro@jp.fujitsu.com, kamezawa.hiroyu@jp.fujitsu.com, linux-mm@kvack.org On 07/11/2013 08:42 AM, Michal Hocko wrote: > On Thu 11-07-13 08:34:45, Dave Hansen wrote: >> On 07/11/2013 05:39 AM, Michal Hocko wrote: >>>> I would turn this into a trace point but that would be much weaker >>>> because the one who is debugging an issue would have to think about >>>> enabling it before the affected workload starts. Which is not possible >>>> quite often. Having logs and looking at them afterwards is so >>>> _convinient_. >> >> It would also be a lot weaker than the printk, but we could always add a >> counter for this stuff and at least dump it out in /proc/vmstat. We >> wouldn't know who was doing it, but we'd at least know someone _was_ >> doing it. It would also have a decent chance of getting picked up by >> existing log collection systems. > > But wouldn't be a counter more intrusive code wise? Dunno, but printk > serves it purpose and it doesn't add much to the code. Yeah, I prefer the printk too. I'd rather see a vmstat entry than a tracepoint, though. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org