From: Li Zefan <lizefan@huawei.com>
To: Tejun Heo <tj@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Glauber Costa <glommer@parallels.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Michal Hocko <mhocko@suse.cz>,
Johannes Weiner <hannes@cmpxchg.org>,
LKML <linux-kernel@vger.kernel.org>,
Cgroups <cgroups@vger.kernel.org>,
linux-mm@kvack.org
Subject: [PATCH v3 6/8] memcg: fail to create cgroup if the cgroup id is too big
Date: Mon, 29 Jul 2013 15:09:08 +0800 [thread overview]
Message-ID: <51F61514.5080702@huawei.com> (raw)
In-Reply-To: <51F614B2.6010503@huawei.com>
memcg requires the cgroup id to be smaller than 65536.
This is a preparation to kill css id.
Signed-off-by: Li Zefan <lizefan@huawei.com>
Acked-by: Michal Hocko <mhocko@suse.cz>
---
mm/memcontrol.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index 62541f5..ad7d7c9 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -512,6 +512,12 @@ static inline bool mem_cgroup_is_root(struct mem_cgroup *memcg)
return (memcg == root_mem_cgroup);
}
+/*
+ * We restrict the id in the range of [1, 65535], so it can fit into
+ * an unsigned short.
+ */
+#define MEM_CGROUP_ID_MAX USHRT_MAX
+
static inline unsigned short mem_cgroup_id(struct mem_cgroup *memcg)
{
/*
@@ -6248,6 +6254,9 @@ mem_cgroup_css_alloc(struct cgroup *cont)
long error = -ENOMEM;
int node;
+ if (cont->id > MEM_CGROUP_ID_MAX)
+ return ERR_PTR(-ENOSPC);
+
memcg = mem_cgroup_alloc();
if (!memcg)
return ERR_PTR(error);
--
1.8.0.2
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-07-29 7:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-29 7:07 [PATCH v3 0/8] memcg, cgroup: kill css_id Li Zefan
2013-07-29 7:07 ` [PATCH v3 1/8] cgroup: convert cgroup_ida to cgroup_idr Li Zefan
2013-07-29 18:28 ` Tejun Heo
2013-07-30 1:10 ` Li Zefan
2013-07-30 14:21 ` Tejun Heo
2013-07-29 7:08 ` [PATCH v3 2/8] cgroup: document how cgroup IDs are assigned Li Zefan
2013-07-29 18:26 ` Tejun Heo
2013-07-30 1:08 ` Li Zefan
2013-07-30 14:22 ` Tejun Heo
2013-07-29 7:08 ` [PATCH v3 3/8] cgroup: implement cgroup_from_id() Li Zefan
2013-07-29 18:31 ` Tejun Heo
2013-07-29 7:08 ` [PATCH v3 4/8] memcg: convert to use cgroup_is_descendant() Li Zefan
2013-07-29 7:08 ` [PATCH v3 5/8] memcg: convert to use cgroup id Li Zefan
2013-07-29 7:09 ` Li Zefan [this message]
2013-07-29 7:09 ` [PATCH v3 7/8] memcg: stop using css id Li Zefan
2013-07-29 7:10 ` [PATCH v3 8/8] cgroup: kill css_id Li Zefan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F61514.5080702@huawei.com \
--to=lizefan@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=glommer@parallels.com \
--cc=hannes@cmpxchg.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).