From: Dave Hansen <dave.hansen@intel.com>
To: Cody P Schafer <cody@linux.vnet.ibm.com>
Cc: Dave Hansen <dave.hansen@linux.intel.com>,
SeungHun Lee <waydi1@gmail.com>,
linux-mm@kvack.org,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
David Rientjes <rientjes@google.com>,
xinxing2zhou@gmail.com
Subject: Re: [PATCH 2/2] mm: page_alloc: Add unlikely for MAX_ORDER check
Date: Tue, 30 Jul 2013 09:43:21 -0700 [thread overview]
Message-ID: <51F7ED29.7080606@intel.com> (raw)
In-Reply-To: <51F714D4.9070005@linux.vnet.ibm.com>
Cody, it's a good point that we shouldn't be looking at something as
simplistic as the file sizes. I also used whole vmlinux's and turned
off debuginfo:
text data bss dec hex filename
10064322 1980968 3051520 15096810 e65bea vmlinux.nothing
10064451 1980968 3051520 15096939 e65c6b vmlinux.unlikely
So it still cost ~130 bytes of text. Also, perusing the vmlinux
objdump, adding the unlikely() does look to take
__alloc_pages_direct_compact and move it _closer_ to the page allocation
code.
What does this all mean? Hell if I know. It's up to the patch
submitter to explain the implications of the patch. ;)
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-07-30 16:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-28 14:48 [PATCH 2/2] mm: page_alloc: Add unlikely for MAX_ORDER check SeungHun Lee
2013-07-29 18:44 ` KOSAKI Motohiro
2013-07-29 22:11 ` David Rientjes
2013-07-29 22:26 ` zhouxinxing
2013-07-29 22:45 ` Dave Hansen
2013-07-30 0:36 ` Cody P Schafer
2013-07-30 0:41 ` Cody P Schafer
2013-07-30 1:20 ` Cody P Schafer
2013-07-30 16:43 ` Dave Hansen [this message]
2013-07-31 14:45 ` 이승훈
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F7ED29.7080606@intel.com \
--to=dave.hansen@intel.com \
--cc=cody@linux.vnet.ibm.com \
--cc=dave.hansen@linux.intel.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
--cc=waydi1@gmail.com \
--cc=xinxing2zhou@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).