From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx121.postini.com [74.125.245.121]) by kanga.kvack.org (Postfix) with SMTP id 16E7F6B0083 for ; Thu, 15 Aug 2013 19:05:59 -0400 (EDT) Received: by mail-ea0-f175.google.com with SMTP id m14so664240eaj.34 for ; Thu, 15 Aug 2013 16:05:57 -0700 (PDT) Message-ID: <520D5ED2.9040403@gmail.com> Date: Fri, 16 Aug 2013 01:05:54 +0200 From: Ben Tebulin MIME-Version: 1.0 Subject: Re: [Bug] Reproducible data corruption on i5-3340M: Please continue your great work! :-) References: <52050382.9060802@gmail.com> <520BB225.8030807@gmail.com> <20130814174039.GA24033@dhcp22.suse.cz> <20130814182756.GD24033@dhcp22.suse.cz> <520C9E78.2020401@gmail.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Linus Torvalds Cc: Ben Tebulin , Michal Hocko , Mel Gorman , Johannes Weiner , Balbir Singh , KAMEZAWA Hiroyuki , linux-mm , Rik van Riel , Andrew Morton , LKML , Peter Zijlstra , "linux-arch@vger.kernel.org" Am 15.08.2013 20:00, schrieb Linus Torvalds: > Ok, so I've slept on it, and here's my current thinking. > [...] Many thoughts which as a user I'm am unable to follow ;-) > This patch tries to fix the interface instead of trying to patch up > the individual places that *should* set the range some particular way > [...] > This patch is against current git, so to apply you need to have > that commit e6c495a96ce0 cherry-picked to older kernels first. I took a shot based on 3.9.11 + e6c495a96ce0. The reason why I don't simply use the current git master is, that for some reasons my linux-image-*.deb become 750MB and larger since 3.10.y and I have no clue at all why and what to do about it. The patch failed. Due to my outstanding incompetence I resorted into applying it onto master, cherry-picking that back and trying to resolve the remaining conflicts correctly. > - I have no idea whether this will fix the problem Ben sees, but I > feel happier about the code, because now any place that forgets to set > up start/end will work just fine, because they are always valid. Simpler code? Resilient API? Happy people? Great! > Ben, please test. I'm worried that the problem you see is something > even more fundamentally wrong with the whole "oops, must flush in the > middle" logic, but I'm _hoping_ this fixes it. It's gone. Really! I git-fsck'ed successfully around 30 times in a row. And even all the other things still seem to work ;-) Honestly I have to confess that I'm deeply impressed how this finally worked out: I just threw a particular, innocent-looking commit hash and nothing more into the round. And while still being unsure if this might be a plain user space issue, only 24h later I received a 11kb sized kernel patch (with blatant typos in it !1! *g* ) apparently solving my issue. /me happy now, too! :) - Ben -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org