From: KOSAKI Motohiro <kosaki.motohiro@gmail.com>
To: Toshi Kani <toshi.kani@hp.com>
Cc: KOSAKI Motohiro <kosaki.motohiro@gmail.com>,
akpm@linux-foundation.org, linux-mm@kvack.org,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
rjw@sisk.pl, kosaki.motohiro@jp.fujitsu.com,
kamezawa.hiroyu@jp.fujitsu.com, tangchen@cn.fujitsu.com,
isimatu.yasuaki@jp.fujitsu.com, liwanp@linux.vnet.ibm.com
Subject: Re: [PATCH] mm/hotplug: Remove stop_machine() from try_offline_node()
Date: Fri, 16 Aug 2013 16:31:15 -0400 [thread overview]
Message-ID: <520E8C13.5020406@gmail.com> (raw)
In-Reply-To: <1376584540.10300.416.camel@misato.fc.hp.com>
>>> This patch removes the use of stop_machine() in try_offline_node() and
>>> adds comments to try_offline_node() and remove_memory() that
>>> lock_device_hotplug() is required.
>>
>> This patch need more verbose explanation. check_cpu_on_node() traverse cpus
>> and cpu hotplug seems to use cpu_hotplug_driver_lock() instead of lock_device_hotplug().
>
> As described:
>
> | lock_device_hotplug() serializes hotplug & online/offline operations.
> | The lock is held in common sysfs online/offline interfaces and ACPI
> | hotplug code paths.
>
> And here are their code paths.
>
> - CPU & Mem online/offline via sysfs online
> store_online()->lock_device_hotplug()
>
> - Mem online via sysfs state:
> store_mem_state()->lock_device_hotplug()
>
> - ACPI CPU & Mem hot-add:
> acpi_scan_bus_device_check()->lock_device_hotplug()
>
> - ACPI CPU & Mem hot-delete:
> acpi_scan_hot_remove()->lock_device_hotplug()
O.K.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-08-16 20:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-12 19:34 [PATCH] mm/hotplug: Remove stop_machine() from try_offline_node() Toshi Kani
2013-08-13 11:41 ` Rafael J. Wysocki
2013-08-13 14:44 ` Toshi Kani
2013-08-15 1:21 ` KOSAKI Motohiro
2013-08-15 16:35 ` Toshi Kani
2013-08-16 20:31 ` KOSAKI Motohiro [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-09-10 0:21 Toshi Kani
2013-09-10 0:23 ` Toshi Kani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=520E8C13.5020406@gmail.com \
--to=kosaki.motohiro@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liwanp@linux.vnet.ibm.com \
--cc=rjw@sisk.pl \
--cc=tangchen@cn.fujitsu.com \
--cc=toshi.kani@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).