From: Chen Gang <gang.chen@asianux.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Al Viro <viro@zeniv.linux.org.uk>, Mel Gorman <mgorman@suse.de>,
rientjes@google.com, sasha.levin@oracle.com,
linux@rasmusvillemoes.dk, kosaki.motohiro@jp.fujitsu.com,
Wu Fengguang <fengguang.wu@intel.com>,
lczerner@redhat.com, linux-mm@kvack.org
Subject: Re: [PATCH] mm: readahead: return the value which force_page_cache_readahead() returns
Date: Wed, 21 Aug 2013 10:29:19 +0800 [thread overview]
Message-ID: <521425FF.0@asianux.com> (raw)
In-Reply-To: <20130820161639.69ffa65b40c5cf761bbb727c@linux-foundation.org>
On 08/21/2013 07:16 AM, Andrew Morton wrote:
> On Tue, 20 Aug 2013 11:31:52 +0800 Chen Gang <gang.chen@asianux.com> wrote:
>
>> force_page_cache_readahead() may fail, so need let the related upper
>> system calls know about it by its return value.
>>
>> Also let related code pass "scripts/checkpatch.pl's" checking.
>>
>> --- a/mm/fadvise.c
>> +++ b/mm/fadvise.c
>> @@ -107,8 +107,8 @@ SYSCALL_DEFINE4(fadvise64_64, int, fd, loff_t, offset, loff_t, len, int, advice)
>> * Ignore return value because fadvise() shall return
>> * success even if filesystem can't retrieve a hint,
>> */
>
> ^^ look.
>
Oh, thanks.
It is my fault, I will send patch v2 for it.
>> - force_page_cache_readahead(mapping, f.file, start_index,
>> - nrpages);
>> + ret = force_page_cache_readahead(mapping, f.file, start_index,
>> + nrpages);
>> break;
>
>
>
Thanks.
--
Chen Gang
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-08-21 2:30 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-20 3:31 [PATCH] mm: readahead: return the value which force_page_cache_readahead() returns Chen Gang
2013-08-20 23:16 ` Andrew Morton
2013-08-21 2:29 ` Chen Gang [this message]
2013-08-21 2:41 ` [PATCH v2] m: " Chen Gang
2013-09-03 5:27 ` Chen Gang
2013-09-17 22:56 ` Andrew Morton
2013-09-18 1:59 ` Chen Gang
2013-10-15 8:06 ` [PATCH] mm/readahead.c: need always return 0 when system call readahead() succeeds Chen Gang
2013-10-15 12:12 ` [PATCH] mm/madvise.c: return 0 instead of read bytes after force_page_cache_readahead() succeeds Chen Gang
2013-10-16 23:06 ` [PATCH] mm/readahead.c: need always return 0 when system call readahead() succeeds David Rientjes
2013-10-17 0:57 ` Chen Gang
2013-10-17 1:17 ` David Rientjes
2013-10-17 1:32 ` Chen Gang
2013-10-17 2:21 ` David Rientjes
2013-10-17 2:37 ` Chen Gang
2013-10-17 2:40 ` Chen Gang
2013-10-15 8:20 ` [PATCH v2] m: readahead: return the value which force_page_cache_readahead() returns Chen Gang
2013-10-17 9:56 ` Chen Gang
2013-11-04 5:31 ` [PATCH v3] mm: readahead: check return " Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=521425FF.0@asianux.com \
--to=gang.chen@asianux.com \
--cc=akpm@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=lczerner@redhat.com \
--cc=linux-mm@kvack.org \
--cc=linux@rasmusvillemoes.dk \
--cc=mgorman@suse.de \
--cc=rientjes@google.com \
--cc=sasha.levin@oracle.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).