From: Jerome Marchand <jmarchan@redhat.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: Dave Hansen <dave.hansen@intel.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2 v2] mm: allow to set overcommit ratio more precisely
Date: Fri, 06 Sep 2013 10:38:52 +0200 [thread overview]
Message-ID: <5229949C.6090904@redhat.com> (raw)
In-Reply-To: <20130905221140.GA29867@amd.pavel.ucw.cz>
On 09/06/2013 12:11 AM, Pavel Machek wrote:
> hi!
>
>>>> This patch adds the new overcommit_ratio_ppm sysctl variable that
>>>> allow to set overcommit ratio with a part per million precision.
>>>> The old overcommit_ratio variable can still be used to set and read
>>>> the ratio with a 1% precision. That way, overcommit_ratio interface
>>>> isn't broken in any way that I can imagine.
>>>
>>> Looks like a pretty sane solution. Could you also make a Documentation/
>>> update, please?
>>
>> Damn! I forgot. Will do.
>
> Actually... would something like overcommit_bytes be better interface? overcommit_pages?
>
> If system would normally allow allocating "n" pages, with overcommit
> it would allow allocating "n + overcommit_pages" pages. That seems
> like right granularity...
>
I don't know what do you mean by "normally".
Anyway, I've considered that option: my concern about mixing absolute and
proportional values is that they would diverge if the amount of ram varies
(e.g. memory hotplug or virt baloon driver).
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-09-06 8:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-19 15:17 [PATCH 1/2] mm: factor commit limit calculation Jerome Marchand
2013-08-19 15:17 ` [PATCH 2/2] mm: add overcommit_kbytes sysctl variable Jerome Marchand
2013-08-19 16:55 ` Dave Hansen
2013-08-20 8:58 ` Jerome Marchand
2013-08-21 15:22 ` Jerome Marchand
2013-08-21 16:23 ` Dave Hansen
2013-08-22 9:25 ` Jerome Marchand
2013-09-05 12:51 ` [PATCH 2/2 v2] mm: allow to set overcommit ratio more precisely Jerome Marchand
2013-09-05 14:41 ` Dave Hansen
2013-09-05 14:47 ` Jerome Marchand
2013-09-05 22:11 ` Pavel Machek
2013-09-06 8:38 ` Jerome Marchand [this message]
2013-09-06 14:11 ` [PATCH 2/2 v3] " Jerome Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5229949C.6090904@redhat.com \
--to=jmarchan@redhat.com \
--cc=dave.hansen@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).