[PATCH 1/2] mm/hotplug: rename the function is_memblock_offlined_cb()

[PATCH 1/2] mm/hotplug: rename the function is_memblock_offlined_cb()

[Xishi Qiu]

Function is_memblock_offlined() return 1 means memory block is offlined,
but is_memblock_offlined_cb() return 1 means memory block is not offlined, 
this will confuse somebody, so rename the function.

Signed-off-by: Xishi Qiu <qiuxishi@huawei.com>
Acked-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
---
 mm/memory_hotplug.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
index ca1dd3a..85f80b7 100644
--- a/mm/memory_hotplug.c
+++ b/mm/memory_hotplug.c
@@ -1657,7 +1657,7 @@ int walk_memory_range(unsigned long start_pfn, unsigned long end_pfn,
 }
 
 #ifdef CONFIG_MEMORY_HOTREMOVE
-static int is_memblock_offlined_cb(struct memory_block *mem, void *arg)
+static int check_memblock_offlined_cb(struct memory_block *mem, void *arg)
 {
 	int ret = !is_memblock_offlined(mem);
 
@@ -1794,7 +1794,7 @@ void __ref remove_memory(int nid, u64 start, u64 size)
 	 * if this is not the case.
 	 */
 	ret = walk_memory_range(PFN_DOWN(start), PFN_UP(start + size - 1), NULL,
-				is_memblock_offlined_cb);
+				check_memblock_offlined_cb);
 	if (ret) {
 		unlock_memory_hotplug();
 		BUG();
-- 
1.7.1


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [PATCH 1/2] mm/hotplug: rename the function is_memblock_offlined_cb()

[Yasuaki Ishimatsu]

[CCing Kosaki since he maintains mm/memory_hotplug.c]

(2013/09/09 12:27), Xishi Qiu wrote:
> Function is_memblock_offlined() return 1 means memory block is offlined,
> but is_memblock_offlined_cb() return 1 means memory block is not offlined,
> this will confuse somebody, so rename the function.
>

> Signed-off-by: Xishi Qiu <qiuxishi@huawei.com>
> Acked-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
> ---

I have not acked your previous patch yet. But this patch seems good to me.
So I acked the patch.

Thanks,
Yasuaki Ishimatsu

>   mm/memory_hotplug.c |    4 ++--
>   1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
> index ca1dd3a..85f80b7 100644
> --- a/mm/memory_hotplug.c
> +++ b/mm/memory_hotplug.c
> @@ -1657,7 +1657,7 @@ int walk_memory_range(unsigned long start_pfn, unsigned long end_pfn,
>   }
>
>   #ifdef CONFIG_MEMORY_HOTREMOVE
> -static int is_memblock_offlined_cb(struct memory_block *mem, void *arg)
> +static int check_memblock_offlined_cb(struct memory_block *mem, void *arg)
>   {
>   	int ret = !is_memblock_offlined(mem);
>
> @@ -1794,7 +1794,7 @@ void __ref remove_memory(int nid, u64 start, u64 size)
>   	 * if this is not the case.
>   	 */
>   	ret = walk_memory_range(PFN_DOWN(start), PFN_UP(start + size - 1), NULL,
> -				is_memblock_offlined_cb);
> +				check_memblock_offlined_cb);
>   	if (ret) {
>   		unlock_memory_hotplug();
>   		BUG();
>


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [PATCH 1/2] mm/hotplug: rename the function is_memblock_offlined_cb()

[Xishi Qiu]

On 2013/9/9 14:08, Yasuaki Ishimatsu wrote:

> [CCing Kosaki since he maintains mm/memory_hotplug.c]
> 
> (2013/09/09 12:27), Xishi Qiu wrote:
>> Function is_memblock_offlined() return 1 means memory block is offlined,
>> but is_memblock_offlined_cb() return 1 means memory block is not offlined,
>> this will confuse somebody, so rename the function.
>>
> 
>> Signed-off-by: Xishi Qiu <qiuxishi@huawei.com>
>> Acked-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
>> ---
> 
> I have not acked your previous patch yet. But this patch seems good to me.
> So I acked the patch.
> 

Sorry, I mistakenly thought "seems good to me" was the same as acked, I'll pay 
attention next time.

Thanks,
Xishi Qiu

> Thanks,
> Yasuaki Ishimatsu
> 
>>   mm/memory_hotplug.c |    4 ++--
>>   1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
>> index ca1dd3a..85f80b7 100644
>> --- a/mm/memory_hotplug.c
>> +++ b/mm/memory_hotplug.c
>> @@ -1657,7 +1657,7 @@ int walk_memory_range(unsigned long start_pfn, unsigned long end_pfn,
>>   }
>>
>>   #ifdef CONFIG_MEMORY_HOTREMOVE
>> -static int is_memblock_offlined_cb(struct memory_block *mem, void *arg)
>> +static int check_memblock_offlined_cb(struct memory_block *mem, void *arg)
>>   {
>>       int ret = !is_memblock_offlined(mem);
>>
>> @@ -1794,7 +1794,7 @@ void __ref remove_memory(int nid, u64 start, u64 size)
>>        * if this is not the case.
>>        */
>>       ret = walk_memory_range(PFN_DOWN(start), PFN_UP(start + size - 1), NULL,
>> -                is_memblock_offlined_cb);
>> +                check_memblock_offlined_cb);
>>       if (ret) {
>>           unlock_memory_hotplug();
>>           BUG();
>>
> 
> 
> 
> 



--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>