From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F50BC54E5D for ; Mon, 18 Mar 2024 09:59:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B229D6B0082; Mon, 18 Mar 2024 05:59:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AD2436B0087; Mon, 18 Mar 2024 05:59:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 972B06B0088; Mon, 18 Mar 2024 05:59:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 8912C6B0082 for ; Mon, 18 Mar 2024 05:59:39 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 31FEDA0DA6 for ; Mon, 18 Mar 2024 09:59:39 +0000 (UTC) X-FDA: 81909712878.16.4156EFC Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf04.hostedemail.com (Postfix) with ESMTP id E6CCF40014 for ; Mon, 18 Mar 2024 09:59:36 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=RRbF4ST6; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710755977; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dGBlSDoutOoOHs5kO76q6zhE4tLhiDFQ2avniqecbWI=; b=Pak6IhBN0S48UojlqDnxmHP4mcp11eIqkBpo2I1GRtXmkAcFdtv95txt5Px2RR1j8xhe2c g0e4yg7P1c+xex81y0zTeHPqCNPDFUwU9Sf9lZUJdy3XVVbCEHq5mwJgpCC7rXwckGjXwn mWljLe3FAbOlaeDDVB6IbbUEX6Y4s+M= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710755977; a=rsa-sha256; cv=none; b=G90jGwFFE0UNxwkm30B4D6SYF+4oGA/4le6djZ9F/ZX9jsVn9Hn50Iy55trm5qSyXzhJqJ f0QA/YJQ/kjdv2v5TnCVjJWH78h05HleS2G/954VSjNHWZVB81L/cXLCI1gb2YTCfeNuL8 eMWoUJadt4sY7LBdhObC9EOjkVvoJ1o= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=RRbF4ST6; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1710755976; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=dGBlSDoutOoOHs5kO76q6zhE4tLhiDFQ2avniqecbWI=; b=RRbF4ST6qbzQJAj8EIWciHlVj9ipl+Gq1LWC9KoRFnhB65up1Y8k+I07SjdzSBqC9xbsmp 5Jz6ZhnL5AmUhmurdbdCO/UgigWCguk2hmq1E9IqkJeNTtEvxx42EGecTIx3MHN/+Cwzqj tt5c/eAmQOfkYY5wbUko556rIx9zPXk= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-642-VerbzYa3OteYM0iLAWAGHQ-1; Mon, 18 Mar 2024 05:59:34 -0400 X-MC-Unique: VerbzYa3OteYM0iLAWAGHQ-1 Received: by mail-lf1-f70.google.com with SMTP id 2adb3069b0e04-513e4499bc7so882637e87.3 for ; Mon, 18 Mar 2024 02:59:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710755973; x=1711360773; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=dGBlSDoutOoOHs5kO76q6zhE4tLhiDFQ2avniqecbWI=; b=ED9jwKsd3PC/QKAf90v92jx/FM9wCW4cSqBPsQN/z6B9ho7S2nyw4jHjUboqngjh97 O7Daa0IwXiZav0zJ6ac8uVD7Y29E7TXmA1bwI7trJzmpCfB96Cht53lTB7xUcS9CWihw rjyrtm6/OTYVmxbQtAJqNlNmEbgOf5rQiOZwZxcf6y/jukNusw5hSla5Qlh23a4Pv/Yu +wajJ1EDy6XWiUMTH6U6ubhUPx3hOpAroHuOBzFHQ5EDOb3dkL8STJFRD4BRMxvpYYxu y+AzG0zdw6YPlh1B6zktllaySk2mGVe+TspwwqcAuU7FUrW9OGL/fi9vC/opiCZq5l2a y5vQ== X-Forwarded-Encrypted: i=1; AJvYcCUkmX5he7roVLHljrxM5a/B+QOWFHgF3GoYVIqNa1Ib87Tl5bno6d7/f6Zlzmi2/wQcygb1wRoWFPQ+c6AZb9a3Qp4= X-Gm-Message-State: AOJu0YwDwmJZXuqx8i0gf+r3AI4k0kvZB3IjlOaQJreeP17brxNpcBvO JYJda1PGiht3V08Lnl+xbTxcIMAsxFvf3TmBxfMVBwRbnHB0EXBwd+plqTjCU4/CcVSx3SMrite yavZ/jywPVXXsB/8rzu7vkMN4/NkfCe53E8TE49G88i45BtHE X-Received: by 2002:a19:ca0b:0:b0:513:dda5:a37f with SMTP id a11-20020a19ca0b000000b00513dda5a37fmr4202616lfg.23.1710755972709; Mon, 18 Mar 2024 02:59:32 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEVTQnQMJvQuJyU5aR28hgRa1U7hKcw2ByfNcTIIWdqj6HP5PqCe2qdSsBJztkZacC175xhiw== X-Received: by 2002:a19:ca0b:0:b0:513:dda5:a37f with SMTP id a11-20020a19ca0b000000b00513dda5a37fmr4202607lfg.23.1710755972259; Mon, 18 Mar 2024 02:59:32 -0700 (PDT) Received: from ?IPV6:2003:cb:c737:1f00:94ff:246b:30d0:686b? (p200300cbc7371f0094ff246b30d0686b.dip0.t-ipconnect.de. [2003:cb:c737:1f00:94ff:246b:30d0:686b]) by smtp.gmail.com with ESMTPSA id v14-20020a05600c444e00b004140a757256sm5467703wmn.31.2024.03.18.02.59.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Mar 2024 02:59:31 -0700 (PDT) Message-ID: <522cd833-c09e-49d8-a79a-6811cf5f9abd@redhat.com> Date: Mon, 18 Mar 2024 10:59:30 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] mm/ksm: fix ksm exec support for prctl To: Jinjiang Tu , akpm@linux-foundation.org, shr@devkernel.io, hannes@cmpxchg.org, riel@surriel.com, wangkefeng.wang@huawei.com, sunnanyong@huawei.com, linux-mm@kvack.org References: <20240318090441.179486-1-tujinjiang@huawei.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240318090441.179486-1-tujinjiang@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: or68fmfbxbtk5jy7838ktuxropcxrxn1 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: E6CCF40014 X-Rspam-User: X-HE-Tag: 1710755976-936956 X-HE-Meta: U2FsdGVkX19HsTtpK2m+gyIUFmMnus1NURkf/yOJ1z9fZUHc3YOVZ1mW9zmhNwCTtJU4leRCTeZOilY2L6faGgb/w6BDe62erYU/DTMpxeX8XiKRW4RMbgPw+7S2xdtjEUyUGesGi+Maq0elzAiZ+c8ywoN1pAFXkSBFU2Gx9+BQ+W8PMow7+sJTi5AlmSWVwq80UUTn8FDkZfN1Cld61bMSzurf9QBMI6dzdeKM96CjqvLdS86E96xtkvTaAqj4Ji9WHZBx42NcenAzZ048M8fVYX8isWaCiPz7GgwT6b3gyZP2oBJR4H8OxSV91PYtAa8hc6EvNkGArCV9RSz56AIPcqtuve5mtZhBMCo8b3jcYE43yRMOJVb4ysIDW+DqpYhjs6DsPey+ZqtHtpC3jRMcexIL5Hw4PgVwKfZ7gT3ec8UcasNwchfRmo6eRXodXGpL77HqLmk1sligEfPmU2SzP0Ds+q7zISfJlTWONud7UTqe8gj7pnLUr3ROk49+qCFYEtSThU0Kmv/HbAB4BYOZ5Coe+4cRa35Dk5PpAbI0nB5St5GIGQLMWef6POYFTGkorbLW5Le+wLw3ncELzoHZ963Hp0xqQw4P2eIMRo4QmbgSCUbpa5gXlPtvJwaaV7ITE/GfSWC+ziJ181MIYoAq0PD37VAnV3BqDXclOgtDyHXwAeMGolC9T6lyO+z/JIai0/bkBLF3REecP5EHrkaoUAPA+WwlKWIz/2TX07xxW77fZz3aMv0UFeipFbiRQSDkXHeQV9bouRMHsgttdp3oTccI6ciZGvyhd4dM3D+g6n18QxyyKmUnXwzCp8r1xL3syJBFuKAqTQnvJlpzWOFY849YSZx8Yrsdeoc7labfkLXQQrv/RKClpdI3p6YoU1JcEqM1fhE1FrrsKzD/rBWLn7duEollr6qxeP15nLWD1n+oWauZ9x29mkhk5b8G5oKTP98uGs1KMMQa005 U5RJSqGY +xzM/8AVXEbj8B0yUQZMKhXE6/i9PppnPH2pum7bNiXD2goRyKLHO7Tc4hzf5OUS5EmYJejpIpTyw0uHwZqhfLG2D2EZAR76Me+4vWmWoCxWl80adeRkg7DluVFSeXxQpFwW8TKBcYPNgyzjn4KF++O+JRSovRZE2QBDe9sC5Zeez/GFJE7NG5vamWGVyO6Nw/f3C+WQP8zDsvWzxvmPdOMIgqlX3GC1E954d4SXPrfd2a3uyYUFQqWKHXXtHg7elKQJsX2KLRo2kVP/kVPKWTLy1i44uRNJYh8ZJjsZ1LErW/cZk21McpA3c0gtkp/aEtBzJAIGroMjyWdF2Qj4nGbEEVanOfgeONIUiE6kps6Kqy+lgC7O73K+vsD/Tnpi4r07slTikPHySvLyPBn2KODYERwhdiisCLroDoBGkmBAhTf7lEQn9SodeAAFxDOeNzBja X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 18.03.24 10:04, Jinjiang Tu wrote: > commit 3c6f33b7273a ("mm/ksm: support fork/exec for prctl") inherits > MMF_VM_MERGE_ANY flag when a task calls execve(). Howerver, it doesn't > create the mm_slot, so ksmd will not try to scan this task. > > To fix it, allocate and add the mm_slot to ksm_mm_head in __bprm_mm_init() > when the mm has MMF_VM_MERGE_ANY flag. > > Fixes: 3c6f33b7273a ("mm/ksm: support fork/exec for prctl") > Signed-off-by: Jinjiang Tu > --- Can we also please extend the KSM selftest? tools/testing/selftests/mm/ksm_functional_tests.c We do have test_prctl_fork_exec(), but in ksm_fork_exec_child() we only test if the flag is set, not if de-duplication using the ksm daemon actually works. -- Cheers, David / dhildenb