From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f170.google.com (mail-pd0-f170.google.com [209.85.192.170]) by kanga.kvack.org (Postfix) with ESMTP id 78D326B0037 for ; Tue, 24 Sep 2013 09:35:17 -0400 (EDT) Received: by mail-pd0-f170.google.com with SMTP id x10so4632228pdj.29 for ; Tue, 24 Sep 2013 06:35:17 -0700 (PDT) Received: by mail-pb0-f47.google.com with SMTP id rr4so4581081pbb.34 for ; Tue, 24 Sep 2013 06:35:14 -0700 (PDT) Message-ID: <524194F6.4000101@gmail.com> Date: Tue, 24 Sep 2013 21:34:46 +0800 From: Zhang Yanfei MIME-Version: 1.0 Subject: Re: [PATCH 4/6] x86/mem-hotplug: Support initialize page tables bottom up References: <524162DA.30004@cn.fujitsu.com> <5241649B.3090302@cn.fujitsu.com> <20130924123340.GE2366@htj.dyndns.org> <52419264.3020409@gmail.com> <20130924132727.GI2366@htj.dyndns.org> In-Reply-To: <20130924132727.GI2366@htj.dyndns.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Tejun Heo Cc: Zhang Yanfei , "Rafael J . Wysocki" , lenb@kernel.org, Thomas Gleixner , mingo@elte.hu, "H. Peter Anvin" , Andrew Morton , Toshi Kani , Wanpeng Li , Thomas Renninger , Yinghai Lu , Jiang Liu , Wen Congyang , Lai Jiangshan , isimatu.yasuaki@jp.fujitsu.com, izumi.taku@jp.fujitsu.com, Mel Gorman , Minchan Kim , mina86@mina86.com, gong.chen@linux.intel.com, vasilis.liaskovitis@profitbricks.com, lwoodman@redhat.com, Rik van Riel , jweiner@redhat.com, prarit@redhat.com, "x86@kernel.org" , linux-doc@vger.kernel.org, "linux-kernel@vger.kernel.org" , Linux MM , linux-acpi@vger.kernel.org, imtangchen@gmail.com On 09/24/2013 09:27 PM, Tejun Heo wrote: > On Tue, Sep 24, 2013 at 09:23:48PM +0800, Zhang Yanfei wrote: >>> Hmm... so, this is kinda weird. We're doing it in two chunks and >>> mapping memory between ISA_END_ADDRESS and kernel_end right on top of >>> ISA_END_ADDRESS? Can't you give enough information to the mapping >>> function so that it can map everything on top of kernel_end in single >>> go? >> >> You mean we should call memory_map_bottom_up like this: >> >> memory_map_bottom_up(ISA_END_ADDRESS, end) >> >> right? > > But that wouldn't be ideal as we want the page tables above kernel > image and the above would allocate it above ISA_END_ADDRESS, right? The original idea is we will allocate everything above the kernel. So the pagetables for [ISA_END_ADDRESS, kernel_end) will be also located above the kernel. > Maybe memory_map_bottom_up() should take extra parameters for where to > allocate page tables at separately from the mapping range and treat it > specially? Would that make the function a lot more complex? Hmmmm...I will try to see if it is complex. Thanks. > > Thanks. > -- Thanks. Zhang Yanfei -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org