From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f169.google.com (mail-pd0-f169.google.com [209.85.192.169]) by kanga.kvack.org (Postfix) with ESMTP id A91C36B0032 for ; Thu, 26 Sep 2013 12:51:57 -0400 (EDT) Received: by mail-pd0-f169.google.com with SMTP id r10so1419025pdi.28 for ; Thu, 26 Sep 2013 09:51:57 -0700 (PDT) Received: by mail-pb0-f51.google.com with SMTP id jt11so1372164pbb.24 for ; Thu, 26 Sep 2013 09:51:54 -0700 (PDT) Message-ID: <52446618.7070703@gmail.com> Date: Fri, 27 Sep 2013 00:51:36 +0800 From: Zhang Yanfei MIME-Version: 1.0 Subject: Re: [PATCH v5 2/6] memblock: Introduce bottom-up allocation mode References: <5241D897.1090905@gmail.com> <5241D9A4.4080305@gmail.com> <20130926144516.GD3482@htj.dyndns.org> <524454BE.4030602@gmail.com> In-Reply-To: <524454BE.4030602@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Tejun Heo Cc: "Rafael J . Wysocki" , lenb@kernel.org, Thomas Gleixner , mingo@elte.hu, "H. Peter Anvin" , Andrew Morton , Toshi Kani , Wanpeng Li , Thomas Renninger , Yinghai Lu , Jiang Liu , Wen Congyang , Lai Jiangshan , isimatu.yasuaki@jp.fujitsu.com, izumi.taku@jp.fujitsu.com, Mel Gorman , Minchan Kim , mina86@mina86.com, gong.chen@linux.intel.com, vasilis.liaskovitis@profitbricks.com, lwoodman@redhat.com, Rik van Riel , jweiner@redhat.com, prarit@redhat.com, "x86@kernel.org" , linux-doc@vger.kernel.org, "linux-kernel@vger.kernel.org" , Linux MM , linux-acpi@vger.kernel.org, imtangchen@gmail.com, Zhang Yanfei On 09/26/2013 11:37 PM, Zhang Yanfei wrote: > Hello tejun, > > Thanks for your quick comments first:) > > On 09/26/2013 10:45 PM, Tejun Heo wrote: >> Hello, >> >> On Wed, Sep 25, 2013 at 02:27:48AM +0800, Zhang Yanfei wrote: >>> +#ifdef CONFIG_MOVABLE_NODE >>> +static inline void memblock_set_bottom_up(bool enable) >>> +{ >>> + memblock.bottom_up = enable; >>> +} >>> + >>> +static inline bool memblock_bottom_up(void) >>> +{ >>> + return memblock.bottom_up; >>> +} >> >> Can you please explain what this is for here? > > OK, will do. I write the function description here so you could give your comments still in this version. /* * Set the allocation direction to bottom-up or top-down. */ static inline void memblock_set_bottom_up(bool enable) { memblock.bottom_up = enable; } /* * Check if the allocation direction is bottom-up or not. * if this is true, that said, the boot option "movablenode" * has been specified, and memblock will allocate memory * just near the kernel image. */ static inline bool memblock_bottom_up(void) { return memblock.bottom_up; } Thanks. -- Thanks. Zhang Yanfei -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org