From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pb0-f47.google.com (mail-pb0-f47.google.com [209.85.160.47]) by kanga.kvack.org (Postfix) with ESMTP id 7154F6B0032 for ; Thu, 26 Sep 2013 12:57:02 -0400 (EDT) Received: by mail-pb0-f47.google.com with SMTP id rr4so1388694pbb.34 for ; Thu, 26 Sep 2013 09:57:02 -0700 (PDT) Received: by mail-pa0-f49.google.com with SMTP id ld10so1571711pab.22 for ; Thu, 26 Sep 2013 09:56:59 -0700 (PDT) Message-ID: <52446748.7090001@gmail.com> Date: Fri, 27 Sep 2013 00:56:40 +0800 From: Zhang Yanfei MIME-Version: 1.0 Subject: Re: [PATCH v5 3/6] x86/mm: Factor out of top-down direct mapping setup References: <5241D897.1090905@gmail.com> <5241D9F2.80908@gmail.com> <20130926144642.GE3482@htj.dyndns.org> <5244553A.2050700@gmail.com> In-Reply-To: <5244553A.2050700@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Tejun Heo Cc: "Rafael J . Wysocki" , lenb@kernel.org, Thomas Gleixner , mingo@elte.hu, "H. Peter Anvin" , Andrew Morton , Toshi Kani , Wanpeng Li , Thomas Renninger , Yinghai Lu , Jiang Liu , Wen Congyang , Lai Jiangshan , isimatu.yasuaki@jp.fujitsu.com, izumi.taku@jp.fujitsu.com, Mel Gorman , Minchan Kim , mina86@mina86.com, gong.chen@linux.intel.com, vasilis.liaskovitis@profitbricks.com, lwoodman@redhat.com, Rik van Riel , jweiner@redhat.com, prarit@redhat.com, "x86@kernel.org" , linux-doc@vger.kernel.org, "linux-kernel@vger.kernel.org" , Linux MM , linux-acpi@vger.kernel.org, imtangchen@gmail.com, Zhang Yanfei Hello tejun, On 09/26/2013 11:39 PM, Zhang Yanfei wrote: > On 09/26/2013 10:46 PM, Tejun Heo wrote: >> On Wed, Sep 25, 2013 at 02:29:06AM +0800, Zhang Yanfei wrote: >>> +/** >>> + * memory_map_top_down - Map [map_start, map_end) top down >>> + * @map_start: start address of the target memory range >>> + * @map_end: end address of the target memory range >>> + * >>> + * This function will setup direct mapping for memory range >>> + * [map_start, map_end) in top-down. >> >> Can you please put a bit more effort into the function description? > > Sorry.... I will try to make a more detailed description. Trying below: /** * memory_map_top_down - Map [map_start, map_end) top down * @map_start: start address of the target memory range * @map_end: end address of the target memory range * * This function will setup direct mapping for memory range * [map_start, map_end) in top-down. That said, the page tables * will be allocated at the end of the memory, and we map the * memory top-down. */ static void __init memory_map_top_down(unsigned long map_start, unsigned long map_end) { Thanks. > >> >> Other than that, >> >> Acked-by: Tejun Heo > > Thanks. > -- Thanks. Zhang Yanfei -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org