From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pb0-f50.google.com (mail-pb0-f50.google.com [209.85.160.50]) by kanga.kvack.org (Postfix) with ESMTP id 576C56B0032 for ; Thu, 26 Sep 2013 13:00:56 -0400 (EDT) Received: by mail-pb0-f50.google.com with SMTP id uo5so1391179pbc.37 for ; Thu, 26 Sep 2013 10:00:56 -0700 (PDT) Received: by mail-pa0-f43.google.com with SMTP id hz1so1573057pad.2 for ; Thu, 26 Sep 2013 10:00:53 -0700 (PDT) Message-ID: <52446834.8090708@gmail.com> Date: Fri, 27 Sep 2013 01:00:36 +0800 From: Zhang Yanfei MIME-Version: 1.0 Subject: Re: [PATCH v5 4/6] x86/mem-hotplug: Support initialize page tables in bottom-up References: <5241D897.1090905@gmail.com> <5241DA5B.8000909@gmail.com> <20130926144851.GF3482@htj.dyndns.org> In-Reply-To: <20130926144851.GF3482@htj.dyndns.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Tejun Heo Cc: "Rafael J . Wysocki" , lenb@kernel.org, Thomas Gleixner , mingo@elte.hu, "H. Peter Anvin" , Andrew Morton , Toshi Kani , Wanpeng Li , Thomas Renninger , Yinghai Lu , Jiang Liu , Wen Congyang , Lai Jiangshan , isimatu.yasuaki@jp.fujitsu.com, izumi.taku@jp.fujitsu.com, Mel Gorman , Minchan Kim , mina86@mina86.com, gong.chen@linux.intel.com, vasilis.liaskovitis@profitbricks.com, lwoodman@redhat.com, Rik van Riel , jweiner@redhat.com, prarit@redhat.com, "x86@kernel.org" , linux-doc@vger.kernel.org, "linux-kernel@vger.kernel.org" , Linux MM , linux-acpi@vger.kernel.org, imtangchen@gmail.com, Zhang Yanfei On 09/26/2013 10:48 PM, Tejun Heo wrote: > Hello, > > On Wed, Sep 25, 2013 at 02:30:51AM +0800, Zhang Yanfei wrote: >> +/** >> + * memory_map_bottom_up - Map [map_start, map_end) bottom up >> + * @map_start: start address of the target memory range >> + * @map_end: end address of the target memory range >> + * >> + * This function will setup direct mapping for memory range >> + * [map_start, map_end) in bottom-up. > > Ditto about the comment. Trying below: /** * memory_map_bottom_up - Map [map_start, map_end) bottom up * @map_start: start address of the target memory range * @map_end: end address of the target memory range * * This function will setup direct mapping for memory range * [map_start, map_end) in bottom-up. Since we have limited the * bottom-up allocation above the kernel, the page tables will * be allocated just above the kernel and we map the memory * in [map_start, map_end) in bottom-up. */ static void __init memory_map_bottom_up(unsigned long map_start, unsigned long map_end) { Thanks. -- Thanks. Zhang Yanfei -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org