From: John Stultz <john.stultz@linaro.org>
To: Zhan Jianyu <nasa4836@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Minchan Kim <minchan@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Android Kernel Team <kernel-team@android.com>,
Robert Love <rlove@google.com>, Mel Gorman <mel@csn.ul.ie>,
Hugh Dickins <hughd@google.com>,
Dave Hansen <dave.hansen@intel.com>,
Rik van Riel <riel@redhat.com>,
Dmitry Adamushko <dmitry.adamushko@gmail.com>,
Dave Chinner <david@fromorbit.com>, Neil Brown <neilb@suse.de>,
Andrea Righi <andrea@betterlinux.com>,
Andrea Arcangeli <aarcange@redhat.com>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
Mike Hommey <mh@glandium.org>, Taras Glek <tglek@mozilla.com>,
Dhaval Giani <dhaval.giani@gmail.com>, Jan Kara <jack@suse.cz>,
KOSAKI Motohiro <kosaki.motohiro@gmail.com>,
Michel Lespinasse <walken@google.com>,
Rob Clark <robdclark@gmail.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: [PATCH 07/14] vrange: Purge volatile pages when memory is tight
Date: Tue, 08 Oct 2013 09:22:52 -0700 [thread overview]
Message-ID: <5254315C.70401@linaro.org> (raw)
In-Reply-To: <CAHz2CGWS+jWQU=v=5AnAgab1DrPr+snWvc62mf43Tx0aQUA8nA@mail.gmail.com>
On 10/07/2013 08:27 PM, Zhan Jianyu wrote:
> On Thu, Oct 3, 2013 at 8:51 AM, John Stultz <john.stultz@linaro.org> wrote:
>> static inline int page_referenced(struct page *page, int is_locked,
>> struct mem_cgroup *memcg,
>> - unsigned long *vm_flags)
>> + unsigned long *vm_flags,
>> + int *is_vrange)
>> {
>> *vm_flags = 0;
>> + *is_vrange = 0;
>> return 0;
>> }
> I don't know if it is appropriate to add a parameter in such a core
> function for an optional functionality. Maybe the is_vrange flag
> should be squashed into the vm_flags ? I am not sure .
Yea, this wasn't either Minchan or I were particularly fond of, but with
the vm_flags exausted, there wasn't a clear way to do so without doing
the rmap traversal again.
Other suggestions? Extending the vm_flags to 64bits is something many
better mm devs have tried to merge unsuccessfully, so I'm hesitant to
try pushing it myself.
thanks
-john
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-10-08 16:23 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-03 0:51 [PATCH 00/14] Volatile Ranges v9 John Stultz
2013-10-03 0:51 ` [PATCH 01/14] vrange: Add basic data structure and functions John Stultz
2013-10-03 0:51 ` [PATCH 02/14] vrange: Add vrange support to mm_structs John Stultz
2013-10-03 0:51 ` [PATCH 03/14] vrange: Clear volatility on new mmaps John Stultz
2013-10-03 0:51 ` [PATCH 04/14] vrange: Add support for volatile ranges on file mappings John Stultz
2013-10-03 0:51 ` [PATCH 05/14] vrange: Add new vrange(2) system call John Stultz
2013-10-07 22:56 ` H. Peter Anvin
2013-10-07 23:14 ` John Stultz
2013-10-07 23:26 ` H. Peter Anvin
2013-10-07 23:41 ` John Stultz
2013-10-07 23:46 ` H. Peter Anvin
2013-10-07 23:54 ` John Stultz
2013-10-07 23:59 ` H. Peter Anvin
2013-10-08 0:13 ` Minchan Kim
2013-10-08 0:18 ` John Stultz
2013-10-08 0:34 ` Minchan Kim
2013-10-08 0:38 ` Minchan Kim
2013-10-08 1:24 ` H. Peter Anvin
2013-10-08 2:08 ` Minchan Kim
2013-10-08 2:51 ` KOSAKI Motohiro
2013-10-08 3:07 ` Minchan Kim
2013-10-08 4:35 ` KOSAKI Motohiro
2013-10-08 7:12 ` Minchan Kim
2013-10-08 7:17 ` Minchan Kim
2013-10-08 0:03 ` Minchan Kim
2013-10-08 0:07 ` John Stultz
2013-10-03 0:51 ` [PATCH 06/14] vrange: Add basic functions to purge volatile pages John Stultz
2013-10-03 10:22 ` Krzysztof Kozlowski
2013-10-03 0:51 ` [PATCH 07/14] vrange: Purge volatile pages when memory is tight John Stultz
2013-10-08 3:27 ` Zhan Jianyu
2013-10-08 16:22 ` John Stultz [this message]
2013-10-03 0:51 ` [PATCH 08/14] vrange: Send SIGBUS when user try to access purged page John Stultz
2013-10-03 0:51 ` [PATCH 09/14] vrange: Add vrange LRU list for purging John Stultz
2013-10-03 0:51 ` [PATCH 10/14] vrange: Add core shrinking logic for swapless system John Stultz
2013-10-03 0:51 ` [PATCH 11/14] vrange: Purging vrange-anon pages from shrinker John Stultz
2013-10-03 0:51 ` [PATCH 12/14] vrange: Support background purging for vrange-file John Stultz
2013-10-03 0:51 ` [PATCH 13/14] vrange: Allocate vroot dynamically John Stultz
2013-10-03 0:51 ` [PATCH 14/14] vrange: Add vmstat counter about purged page John Stultz
2013-10-03 23:56 ` [PATCH 00/14] Volatile Ranges v9 John Stultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5254315C.70401@linaro.org \
--to=john.stultz@linaro.org \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=andrea@betterlinux.com \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=dave.hansen@intel.com \
--cc=david@fromorbit.com \
--cc=dhaval.giani@gmail.com \
--cc=dmitry.adamushko@gmail.com \
--cc=hughd@google.com \
--cc=jack@suse.cz \
--cc=kernel-team@android.com \
--cc=kosaki.motohiro@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=mh@glandium.org \
--cc=minchan@kernel.org \
--cc=nasa4836@gmail.com \
--cc=neilb@suse.de \
--cc=riel@redhat.com \
--cc=rlove@google.com \
--cc=robdclark@gmail.com \
--cc=tglek@mozilla.com \
--cc=walken@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).