From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f170.google.com (mail-pd0-f170.google.com [209.85.192.170]) by kanga.kvack.org (Postfix) with ESMTP id 495316B0037 for ; Wed, 9 Oct 2013 19:26:31 -0400 (EDT) Received: by mail-pd0-f170.google.com with SMTP id x10so1696082pdj.29 for ; Wed, 09 Oct 2013 16:26:30 -0700 (PDT) Received: by mail-pb0-f41.google.com with SMTP id rp2so1648769pbb.14 for ; Wed, 09 Oct 2013 16:26:28 -0700 (PDT) Message-ID: <5255E60F.5010102@gmail.com> Date: Thu, 10 Oct 2013 07:26:07 +0800 From: Zhang Yanfei MIME-Version: 1.0 Subject: Re: [PATCH part1 v6 4/6] x86/mem-hotplug: Support initialize page tables in bottom-up References: <524E2032.4020106@gmail.com> <524E2127.4090904@gmail.com> <5251F9AB.6000203@zytor.com> <525442A4.9060709@gmail.com> <20131009164449.GG22495@htj.dyndns.org> <52558EEF.4050009@gmail.com> <20131009192040.GA5592@mtj.dyndns.org> <1381352311.5429.115.camel@misato.fc.hp.com> <20131009211136.GH5592@mtj.dyndns.org> <5255C730.90602@zytor.com> <5255CE7D.8030007@gmail.com> <5255E253.3080905@zytor.com> In-Reply-To: <5255E253.3080905@zytor.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: "H. Peter Anvin" Cc: Tejun Heo , Toshi Kani , Andrew Morton , "Rafael J . Wysocki" , lenb@kernel.org, Thomas Gleixner , mingo@elte.hu, Wanpeng Li , Thomas Renninger , Yinghai Lu , Jiang Liu , Wen Congyang , Lai Jiangshan , isimatu.yasuaki@jp.fujitsu.com, izumi.taku@jp.fujitsu.com, Mel Gorman , Minchan Kim , mina86@mina86.com, gong.chen@linux.intel.com, vasilis.liaskovitis@profitbricks.com, lwoodman@redhat.com, Rik van Riel , jweiner@redhat.com, prarit@redhat.com, "x86@kernel.org" , linux-doc@vger.kernel.org, "linux-kernel@vger.kernel.org" , Linux MM , linux-acpi@vger.kernel.org, imtangchen@gmail.com, Zhang Yanfei , Tang Chen Hello Peter, On 10/10/2013 07:10 AM, H. Peter Anvin wrote: > On 10/09/2013 02:45 PM, Zhang Yanfei wrote: >>> >>> I would also argue that in the VM scenario -- and arguable even in the >>> hardware scenario -- the right thing is to not expose the flexible >>> memory in the e820/EFI tables, and instead have it hotadded (possibly >>> *immediately* so) on boot. This avoids both the boot time funnies as >>> well as the scaling issues with metadata. >>> >> >> So in this kind of scenario, hotpluggable memory will not be detected >> at boot time, and admin should not use this movable_node boot option >> and the kernel will act as before, using top-down allocation always. >> > > Yes. The idea is that the kernel will boot up without the hotplug > memory, but if desired, will immediately see a hotplug-add event for the > movable memory. Yeah, this is good. But in the scenario that boot with hotplug memory, we need the movable_node option. So as tejun has explained a lot about this patchset, do you still have objection to it or could I ask andrew to merge it into -mm tree for more tests? -- Thanks. Zhang Yanfei -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org