From: Pekka Enberg <penberg@iki.fi>
To: Qiang Huang <h.huangqiang@huawei.com>, akpm@linux-foundation.org
Cc: hannes@cmpxchg.org, mhocko@suse.cz, cl@linux-foundation.org,
penberg@kernel.org, glommer@parallels.com, rientjes@google.com,
cgroups@vger.kernel.org, linux-mm@kvack.org, lizefan@huawei.com
Subject: Re: [PATCH 1/3] memcg, kmem: Use is_root_cache instead of hard code
Date: Thu, 24 Oct 2013 20:30:37 +0300 [thread overview]
Message-ID: <5269593D.8000904@iki.fi> (raw)
In-Reply-To: <1382527875-10112-2-git-send-email-h.huangqiang@huawei.com>
On 10/23/2013 02:31 PM, Qiang Huang wrote:
> Signed-off-by: Qiang Huang <h.huangqiang@huawei.com>
> ---
> mm/memcontrol.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> index b73988a..15ad0e3 100644
> --- a/mm/memcontrol.c
> +++ b/mm/memcontrol.c
> @@ -57,6 +57,7 @@
> #include <net/sock.h>
> #include <net/ip.h>
> #include <net/tcp_memcontrol.h>
> +#include "slab.h"
>
> #include <asm/uaccess.h>
>
> @@ -3064,7 +3065,7 @@ int memcg_update_cache_size(struct kmem_cache *s, int num_groups)
> {
> struct memcg_cache_params *cur_params = s->memcg_params;
>
> - VM_BUG_ON(s->memcg_params && !s->memcg_params->is_root_cache);
> + VM_BUG_ON(!is_root_cache(s));
>
> if (num_groups > memcg_limited_groups_array_size) {
> int i;
Reviewed-by: Pekka Enberg <penberg@kernel.org>
Andrew, I think your tree is the right place for these patches.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-10-24 17:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-23 11:31 [PATCH 0/3] a few cleanups about kmem code Qiang Huang
2013-10-23 11:31 ` [PATCH 1/3] memcg, kmem: Use is_root_cache instead of hard code Qiang Huang
2013-10-24 17:30 ` Pekka Enberg [this message]
2013-10-31 2:35 ` David Rientjes
2013-10-23 11:31 ` [PATCH 2/3] memcg, kmem: rename cache_from_memcg to cache_from_memcg_idx Qiang Huang
2013-10-24 17:31 ` Pekka Enberg
2013-10-31 2:37 ` David Rientjes
2013-10-23 11:31 ` [PATCH 3/3] memcg, kmem: use cache_from_memcg_idx instead of hard code Qiang Huang
2013-10-24 17:31 ` Pekka Enberg
2013-10-31 2:40 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5269593D.8000904@iki.fi \
--to=penberg@iki.fi \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=cl@linux-foundation.org \
--cc=glommer@parallels.com \
--cc=h.huangqiang@huawei.com \
--cc=hannes@cmpxchg.org \
--cc=linux-mm@kvack.org \
--cc=lizefan@huawei.com \
--cc=mhocko@suse.cz \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).