From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f178.google.com (mail-pd0-f178.google.com [209.85.192.178]) by kanga.kvack.org (Postfix) with ESMTP id EF2766B0031 for ; Mon, 28 Oct 2013 12:04:13 -0400 (EDT) Received: by mail-pd0-f178.google.com with SMTP id x10so7058273pdj.37 for ; Mon, 28 Oct 2013 09:04:13 -0700 (PDT) Received: from psmtp.com ([74.125.245.125]) by mx.google.com with SMTP id cj2si12446174pbc.87.2013.10.28.09.04.12 for ; Mon, 28 Oct 2013 09:04:13 -0700 (PDT) Message-ID: <526E8AF9.6070300@codeaurora.org> Date: Mon, 28 Oct 2013 09:04:09 -0700 From: Laura Abbott MIME-Version: 1.0 Subject: Re: [PATCH] mm: cma: free cma page to buddy instead of being cpu hot page References: <1382960569-6564-1-git-send-email-zhang.mingjun@linaro.org> In-Reply-To: <1382960569-6564-1-git-send-email-zhang.mingjun@linaro.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: zhang.mingjun@linaro.org, minchan@kernel.org, m.szyprowski@samsung.com, akpm@linux-foundation.org, mgorman@suse.de, haojian.zhuang@linaro.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Mingjun Zhang On 10/28/2013 4:42 AM, zhang.mingjun@linaro.org wrote: > From: Mingjun Zhang > > free_contig_range frees cma pages one by one and MIGRATE_CMA pages will be > used as MIGRATE_MOVEABLE pages in the pcp list, it causes unnecessary > migration action when these pages reused by CMA. > > Signed-off-by: Mingjun Zhang > --- > mm/page_alloc.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 0ee638f..84b9d84 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -1362,7 +1362,8 @@ void free_hot_cold_page(struct page *page, int cold) > * excessively into the page allocator > */ > if (migratetype >= MIGRATE_PCPTYPES) { > - if (unlikely(is_migrate_isolate(migratetype))) { > + if (unlikely(is_migrate_isolate(migratetype)) > + || is_migrate_cma(migratetype)) > free_one_page(zone, page, 0, migratetype); > goto out; > } > I submitted something very similar a while ago http://marc.info/?l=linaro-mm-sig&m=137645764208287&w=2 . Has the opinion on this patch changed? Thanks, Laura -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org