From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-bk0-f49.google.com (mail-bk0-f49.google.com [209.85.214.49]) by kanga.kvack.org (Postfix) with ESMTP id 3923B6B007B for ; Tue, 26 Nov 2013 09:24:44 -0500 (EST) Received: by mail-bk0-f49.google.com with SMTP id my13so2594957bkb.36 for ; Tue, 26 Nov 2013 06:24:43 -0800 (PST) Received: from mail-bk0-x235.google.com (mail-bk0-x235.google.com [2a00:1450:4008:c01::235]) by mx.google.com with ESMTPS id dc8si10909178bkc.271.2013.11.26.06.24.43 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 26 Nov 2013 06:24:43 -0800 (PST) Received: by mail-bk0-f53.google.com with SMTP id na10so2575599bkb.26 for ; Tue, 26 Nov 2013 06:24:43 -0800 (PST) Message-ID: <5294AF27.8080605@gmail.com> Date: Tue, 26 Nov 2013 15:24:39 +0100 From: Juri Lelli MIME-Version: 1.0 Subject: Re: [PATCH] cpuset: Fix memory allocator deadlock References: <20131126140341.GL10022@twins.programming.kicks-ass.net> In-Reply-To: <20131126140341.GL10022@twins.programming.kicks-ass.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Peter Zijlstra , Li Zefan , Tejun Heo Cc: John Stultz , Mel Gorman , linux-kernel@vger.kernel.org, linux-mm@kvack.org On 11/26/2013 03:03 PM, Peter Zijlstra wrote: > Juri hit the below lockdep report: > > [ 4.303391] ====================================================== > [ 4.303392] [ INFO: SOFTIRQ-safe -> SOFTIRQ-unsafe lock order detected ] > [ 4.303394] 3.12.0-dl-peterz+ #144 Not tainted > [ 4.303395] ------------------------------------------------------ > [ 4.303397] kworker/u4:3/689 [HC0[0]:SC0[0]:HE0:SE1] is trying to acquire: > [ 4.303399] (&p->mems_allowed_seq){+.+...}, at: [] new_slab+0x6c/0x290 > [ 4.303417] > [ 4.303417] and this task is already holding: > [ 4.303418] (&(&q->__queue_lock)->rlock){..-...}, at: [] blk_execute_rq_nowait+0x5b/0x100 > [ 4.303431] which would create a new lock dependency: > [ 4.303432] (&(&q->__queue_lock)->rlock){..-...} -> (&p->mems_allowed_seq){+.+...} > [ 4.303436] > > [ 4.303898] the dependencies between the lock to be acquired and SOFTIRQ-irq-unsafe lock: > [ 4.303918] -> (&p->mems_allowed_seq){+.+...} ops: 2762 { > [ 4.303922] HARDIRQ-ON-W at: > [ 4.303923] [] __lock_acquire+0x65a/0x1ff0 > [ 4.303926] [] lock_acquire+0x93/0x140 > [ 4.303929] [] kthreadd+0x86/0x180 > [ 4.303931] [] ret_from_fork+0x7c/0xb0 > [ 4.303933] SOFTIRQ-ON-W at: > [ 4.303933] [] __lock_acquire+0x68c/0x1ff0 > [ 4.303935] [] lock_acquire+0x93/0x140 > [ 4.303940] [] kthreadd+0x86/0x180 > [ 4.303955] [] ret_from_fork+0x7c/0xb0 > [ 4.303959] INITIAL USE at: > [ 4.303960] [] __lock_acquire+0x344/0x1ff0 > [ 4.303963] [] lock_acquire+0x93/0x140 > [ 4.303966] [] kthreadd+0x86/0x180 > [ 4.303969] [] ret_from_fork+0x7c/0xb0 > [ 4.303972] } > > Which reports that we take mems_allowed_seq with interrupts enabled. A > little digging found that this can only be from > cpuset_change_task_nodemask(). > > This is an actual deadlock because an interrupt doing an allocation will > hit get_mems_allowed()->...->__read_seqcount_begin(), which will spin > forever waiting for the write side to complete. > And this patch fixes it, thanks! > Cc: John Stultz > Cc: Mel Gorman > Reported-by: Juri Lelli > Signed-off-by: Peter Zijlstra Tested-by: Juri Lelli Best, - Juri > --- > kernel/cpuset.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/kernel/cpuset.c b/kernel/cpuset.c > index 6bf981e13c43..4772034b4b17 100644 > --- a/kernel/cpuset.c > +++ b/kernel/cpuset.c > @@ -1033,8 +1033,10 @@ static void cpuset_change_task_nodemask(struct task_struct *tsk, > need_loop = task_has_mempolicy(tsk) || > !nodes_intersects(*newmems, tsk->mems_allowed); > > - if (need_loop) > + if (need_loop) { > + local_irq_disable(); > write_seqcount_begin(&tsk->mems_allowed_seq); > + } > > nodes_or(tsk->mems_allowed, tsk->mems_allowed, *newmems); > mpol_rebind_task(tsk, newmems, MPOL_REBIND_STEP1); > @@ -1042,8 +1044,10 @@ static void cpuset_change_task_nodemask(struct task_struct *tsk, > mpol_rebind_task(tsk, newmems, MPOL_REBIND_STEP2); > tsk->mems_allowed = *newmems; > > - if (need_loop) > + if (need_loop) { > write_seqcount_end(&tsk->mems_allowed_seq); > + local_irq_enable(); > + } > > task_unlock(tsk); > } > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org