From: Chen Gang <gang.chen.5i5j@gmail.com>
To: Seth Jennings <sjenning@linux.vnet.ibm.com>
Cc: linux-mm@kvack.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
James Hogan <james.hogan@imgtec.com>
Subject: [PATCH] mm/zswap.c: add BUG() for default case in zswap_writeback_entry()
Date: Mon, 09 Dec 2013 10:51:16 +0800 [thread overview]
Message-ID: <52A53024.9090701@gmail.com> (raw)
Recommend to add default case to avoid compiler's warning, although at
present, the original implementation is still correct.
The related warning (with allmodconfig for metag):
CC mm/zswap.o
mm/zswap.c: In function 'zswap_writeback_entry':
mm/zswap.c:537: warning: 'ret' may be used uninitialized in this function
Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
---
mm/zswap.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/mm/zswap.c b/mm/zswap.c
index 5a63f78..bfd1807 100644
--- a/mm/zswap.c
+++ b/mm/zswap.c
@@ -585,6 +585,8 @@ static int zswap_writeback_entry(struct zbud_pool *pool, unsigned long handle)
/* page is up to date */
SetPageUptodate(page);
+ default:
+ BUG();
}
/* move it to the tail of the inactive list after end_writeback */
--
1.7.7.6
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2013-12-09 2:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-09 2:51 Chen Gang [this message]
2013-12-09 9:54 ` [PATCH] mm/zswap.c: add BUG() for default case in zswap_writeback_entry() James Hogan
2013-12-09 10:11 ` Chen Gang
2013-12-09 10:18 ` James Hogan
2013-12-09 11:21 ` Chen Gang
2013-12-09 11:40 ` James Hogan
2013-12-09 13:34 ` Chen Gang
2013-12-09 15:36 ` Seth Jennings
2013-12-10 2:16 ` Chen Gang
2013-12-11 2:11 ` [PATCH v2] " Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A53024.9090701@gmail.com \
--to=gang.chen.5i5j@gmail.com \
--cc=james.hogan@imgtec.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sjenning@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).